Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to provide scratch root twice in values.yaml #646

Open
DominicOram opened this issue Sep 20, 2024 · 0 comments
Open

Need to provide scratch root twice in values.yaml #646

DominicOram opened this issue Sep 20, 2024 · 0 comments
Labels
bug Something isn't working helm chart
Milestone

Comments

@DominicOram
Copy link
Contributor

From testing on i04 it was found that to get blueapi to pick up the scratch directory it had to be provided in worker and in initContainer e.g.

worker:
  stomp:
    host: i04-control.diamond.ac.uk
  env:
    events:
      broadcast_status_events: False
    sources:
      - kind: dodal
        module: dodal.beamlines.i04
      - kind: planFunctions
        module: mx_bluesky.beamlines.i04
  scratch:
    root: /blueapi-plugins/scratch
initContainer:
  scratch:
    root: /blueapi-plugins/scratch
    repositories:
      - name: "dodal"
        remote_url: https://github.com/DiamondLightSource/dodal.git
      - name: "mx_bluesky"
        remote_url: https://github.com/DiamondLightSource/mx_bluesky.git
scratchHostPath: /dls_sw/i04/software/bluesky/scratch

This is annoying redundancy but worse is that it does not match the example given in https://github.com/DiamondLightSource/blueapi/blob/main/helm/blueapi/values.yaml

Acceptance Criteria

  • At least, the example is update to say match what is required
  • Ideally I only need to provide the path once
@callumforrester callumforrester added bug Something isn't working helm chart labels Oct 8, 2024
@callumforrester callumforrester added this to the 1.0.0 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working helm chart
Projects
None yet
Development

No branches or pull requests

2 participants