Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove References to inject #679

Open
callumforrester opened this issue Oct 21, 2024 · 0 comments
Open

Remove References to inject #679

callumforrester opened this issue Oct 21, 2024 · 0 comments
Labels
devices connection enhancement New feature or request good first issue Good for newcomers worker Relates to worker code

Comments

@callumforrester
Copy link
Contributor

This feature was deprecated in DiamondLightSource/dodal#854, see that PR and associated issue for the replacement behaviour.

Acceptance Criteria

  • References to inject are removed and replaced with calls to DeviceInitialisationControllers
  • Tests confirm that blueapi can still load the devices into its context and insert them into plans
@callumforrester callumforrester added enhancement New feature or request worker Relates to worker code devices connection good first issue Good for newcomers labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devices connection enhancement New feature or request good first issue Good for newcomers worker Relates to worker code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@callumforrester