-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding oauthn #690
Merged
Merged
Adding oauthn #690
Changes from 70 commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
e810563
added oauth
ZohebShaikh 983ea61
Test refactoring
DiamondJoseph 5ded18a
Linting
DiamondJoseph e6b396c
Move RMQ launch into docker-compose
DiamondJoseph 0d20a46
More changes
DiamondJoseph 365b59e
Refactor tests to not require mocking jwt_decode
DiamondJoseph f23a828
Refactor dependencies
DiamondJoseph a7e0515
Consistency in names
DiamondJoseph c99aa5c
Test changes for mocks
DiamondJoseph 5f5b355
Revert unrelated changes
DiamondJoseph 82f1ddd
Remove vestigial decoupling
DiamondJoseph a6185a5
Revert unrelated changes
DiamondJoseph 0b270d4
Re-use fixtures
DiamondJoseph 3b06ea0
Refresh dev-requirements
DiamondJoseph 2c8e614
Check if access_token is jwt first
DiamondJoseph 69af289
Revert accidental change
DiamondJoseph 13ca9b5
lint
DiamondJoseph 1f2b340
Last test
DiamondJoseph def1ccc
Linting
DiamondJoseph 355b055
whitespace changes
DiamondJoseph bf6000a
Rename fixtures and config
DiamondJoseph 56a5485
Remove useless default for CLIClientConfig
DiamondJoseph 3f9555e
token_path less verbose
DiamondJoseph aef1911
Revert unrelated main changes
DiamondJoseph f875afe
Revert server handling changes
DiamondJoseph 84c9fe0
Remove unused endpoint
DiamondJoseph 3e0f247
Revert unrelated change
DiamondJoseph 34457b9
Ensure logout flow and add required(?) headers
DiamondJoseph 6241a23
Handle exceptions
DiamondJoseph a43ea73
Remove system test config until container provided
DiamondJoseph 7da35dc
Refactored requests to use form-encoded data instead of JSON payloads…
ZohebShaikh 492fe19
added tests for invalid token
ZohebShaikh 1243807
Merge branch 'main' into adding-oauthn
ZohebShaikh b31c275
Merge remote-tracking branch 'origin/main' into adding-oauthn
ZohebShaikh d7cb5e8
Merge branch 'main' into adding-oauthn
DiamondJoseph a3894a7
Prevent issues with using client_audiences as span attributes
DiamondJoseph f200e93
added middleware for oauthn
ZohebShaikh b69d394
using sorted list to compare plans
ZohebShaikh 0638a9c
updated scopes for requests made for login&logout
ZohebShaikh 0a93d16
added sort for devices
ZohebShaikh 2a92349
Merge remote-tracking branch 'origin/main' into adding-oauthn
ZohebShaikh ba3ff6e
added bound for result and post merge changes
ZohebShaikh e649c2d
added match for response
ZohebShaikh d717829
added test for server checking of access token
ZohebShaikh 9d116b1
added test for 401 unauthenticated response
ZohebShaikh 2e365e0
added tests for main server auth
ZohebShaikh 66eee00
made changes to the conftest
ZohebShaikh c015582
added design changes
ZohebShaikh 721fa22
saving access token
ZohebShaikh cd69900
updated flow
ZohebShaikh 638a0cc
simplified getting valid access token
ZohebShaikh f961e51
updated working tests
ZohebShaikh 4904ee2
added unit tests for authentication
ZohebShaikh 8166c4d
removed pytest skip for tests
ZohebShaikh ea471d8
added tests for oauth
ZohebShaikh 27c12ce
simplified tests
ZohebShaikh d7e32b2
added tests for coverage
ZohebShaikh fa30faa
Merge branch 'main' into adding-oauthn
ZohebShaikh 4178ccd
added detail for 401
ZohebShaikh c3899b3
updated system test comment
ZohebShaikh 889730b
updated test
ZohebShaikh 841adcb
added code review changes
ZohebShaikh 9037ce2
added browser to open the login page
ZohebShaikh 45bf6c2
changed name to blueapi
ZohebShaikh 07c9686
deleted expand user check
ZohebShaikh bb52bdb
added code review changes
ZohebShaikh 6fc6b73
updated test
ZohebShaikh e7e9620
Merge remote-tracking branch 'origin/main' into adding-oauthn
ZohebShaikh 48c3c34
added minor changes and increased coverage
ZohebShaikh 7bd63af
added open_new_tab literal
ZohebShaikh 72cbcf5
changed from Blueapi to blueapi
ZohebShaikh a614684
updated system tests
ZohebShaikh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
from .authentication import SessionManager | ||
from .model import DeviceModel, PlanModel | ||
|
||
__all__ = ["PlanModel", "DeviceModel"] | ||
__all__ = ["PlanModel", "DeviceModel", "SessionManager"] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some agreement somewhere on how blueapi should be stylized?
blueAPI
/BlueApi
,Blueapi
etc?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no agreement that I know of but I have seen three ways of using this
blueapi
,Blueapi
andBlueAPI
<- added recently in tracingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's stylised blueapi