Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing transmission issue #1

Open
P-Mousley opened this issue May 31, 2023 · 3 comments
Open

Parsing transmission issue #1

P-Mousley opened this issue May 31, 2023 · 3 comments

Comments

@P-Mousley
Copy link
Contributor

Current format of io._parse_transmission on line 791 does not account for nexus files which are missing any transmission values. Only has two examples of naming instances for where to find the transmission value

@RBrearton
Copy link
Contributor

These were the only places where I’d seen transmission in nexus files. Has it by any chance moved again?!

Maybe the parser methods should fall back to a brute force search of the nexus file for a name (like transmission or fatt) in the event that the location has moved. What do you think?

@P-Mousley
Copy link
Contributor Author

the transmission value is missing from the nexus file entirely - hopefully just a shortlived bug. However i think a solution in the short term could be adding in a fall back of setting transmission to 1 if no value is found, along with a warning somewhere that a default value has been set.
A separate full search of the filetree might be useful, but in the longer term we are working with the GDA/DAQ groups to hopefully stabilise the nexus filetree structure

@RBrearton
Copy link
Contributor

I suppose a nice way to do it could be to set the transmission to 1 just before raising the nexus error that triggers the missing metadata warning. That way a warning will still be written to stderr, but the default value won’t be set to None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants