Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated FP in PVs #32

Open
2 tasks
GDYendell opened this issue Aug 20, 2024 · 1 comment
Open
2 tasks

Remove duplicated FP in PVs #32

GDYendell opened this issue Aug 20, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@GDYendell
Copy link
Contributor

GDYendell commented Aug 20, 2024

e.g. ODIN-118:FP:FP0:Error -> ODIN-118:FP:0:Error

  • Remove FP/FR from subcontroller label when Frame{Processor,Receiver}AdapterController creates its Frame{Processor,Receiver}Controller subcontrollers to use only the index of the process
  • Call set_label with "FPX" so that sub screen title is not just "X"
  • Update tests
  • Check screen generation by running full deployment in odin-data devcontainer (see README)
@GDYendell GDYendell moved this to Backlog in FastCS Development Aug 20, 2024
@GDYendell GDYendell added enhancement New feature or request good first issue Good for newcomers labels Oct 18, 2024
@GDYendell GDYendell moved this from Current Sprint to Backlog in FastCS Development Nov 29, 2024
@GDYendell
Copy link
Contributor Author

GDYendell commented Feb 25, 2025

I think we could fix this in the implementation of ControllerVector. See: DiamondLightSource/FastCS#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

1 participant