Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app local metrics #46

Merged
merged 3 commits into from
Jul 19, 2024
Merged

app local metrics #46

merged 3 commits into from
Jul 19, 2024

Conversation

zoe-codez
Copy link
Member

@zoe-codez zoe-codez commented Jul 13, 2024

Changes

Update metrics so they can't be double registered in weird upgrading edge cases. Causes app crashes requiring removal & reinstall of node_modules

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 65.30612% with 17 lines in your changes missing coverage. Please review.

Project coverage is 71.45%. Comparing base (4d2cd99) to head (829e193).

Files Patch % Lines
src/extensions/cache.extension.ts 44.44% 5 Missing ⚠️
src/helpers/cache-redis.helper.ts 0.00% 5 Missing ⚠️
src/helpers/cache-memory.helper.ts 0.00% 4 Missing ⚠️
src/extensions/fetch.extension.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   71.33%   71.45%   +0.12%     
==========================================
  Files          30       30              
  Lines        1371     1377       +6     
  Branches      187      187              
==========================================
+ Hits          978      984       +6     
  Misses        379      379              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoe-codez zoe-codez merged commit d59004c into main Jul 19, 2024
2 of 3 checks passed
@zoe-codez zoe-codez deleted the local_metrics branch July 19, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant