-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootLibrariesFirst #53
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 71.45% 72.51% +1.05%
==========================================
Files 30 30
Lines 1377 1390 +13
Branches 187 190 +3
==========================================
+ Hits 984 1008 +24
+ Misses 379 368 -11
Partials 14 14 ☔ View full report in Codecov by Sentry. |
@chrisdrackett what do you think of this It'd effectively wait to construct your services until |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Been thinking about it, and I think I really like this new bootLibrariesFirst
option.
Even if opting in to that, it wouldn't be all that hard to opt-in later. At the same time it allows lower threshold of "just writing some automations in services"
Yeah, I think not having to play the dance of "does this need to go in a |
📬 Changes
is.empty
to not explode when numbers are provided to itbootLibrariesFirst
, which will pre-boot libraries before wiring your app🗒️ Checklist
code of conduct