Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootLibrariesFirst #53

Merged
merged 9 commits into from
Aug 12, 2024
Merged

bootLibrariesFirst #53

merged 9 commits into from
Aug 12, 2024

Conversation

zoe-codez
Copy link
Member

@zoe-codez zoe-codez commented Aug 11, 2024

📬 Changes

  • Altered is.empty to not explode when numbers are provided to it
  • types and comments
  • added bootstrap flag bootLibrariesFirst, which will pre-boot libraries before wiring your app
  • resolve More detailed extended boot stats #48 (bug portion)

🗒️ Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme and docs (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (d59004c) to head (f520b63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   71.45%   72.51%   +1.05%     
==========================================
  Files          30       30              
  Lines        1377     1390      +13     
  Branches      187      190       +3     
==========================================
+ Hits          984     1008      +24     
+ Misses        379      368      -11     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoe-codez zoe-codez changed the title Tweaks bootLibrariesFirst Aug 11, 2024
@zoe-codez zoe-codez requested a review from webbertakken August 11, 2024 19:07
@zoe-codez
Copy link
Member Author

zoe-codez commented Aug 11, 2024

@chrisdrackett what do you think of this bootLibrariesFirst flag?

It'd effectively wait to construct your services until onReady is just about to fire. You could ignore the lifecycle for the bootstrap phase inside application code

webbertakken
webbertakken previously approved these changes Aug 11, 2024
Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been thinking about it, and I think I really like this new bootLibrariesFirst option.

Even if opting in to that, it wouldn't be all that hard to opt-in later. At the same time it allows lower threshold of "just writing some automations in services"

@chrisdrackett
Copy link

Yeah, I think not having to play the dance of "does this need to go in a onReady or not?" would be really useful :D

@zoe-codez zoe-codez merged commit 897e1ec into main Aug 12, 2024
3 checks passed
@zoe-codez zoe-codez deleted the tweaks branch August 12, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More detailed extended boot stats
3 participants