Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The history categories are too limited #149

Open
skyli42 opened this issue Sep 10, 2020 · 1 comment
Open

The history categories are too limited #149

skyli42 opened this issue Sep 10, 2020 · 1 comment

Comments

@skyli42
Copy link
Collaborator

skyli42 commented Sep 10, 2020

The current three categories (events, people, trends) definitely don't encompass all of Canadian history and make it difficult to add pages that don't fall cleanly into one of them (e.g. the Blue Jays).

Would need to update the folder structure under history/ and also looks like lib/get-history.js would need to be updated to be more general.
@skyli42
Copy link
Collaborator Author

skyli42 commented Sep 10, 2020

bin/history-please.js is also hardcoded for these three categories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skyli42