Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in custom plot layout #182

Open
cleanylee opened this issue Mar 29, 2023 · 3 comments
Open

Bug in custom plot layout #182

cleanylee opened this issue Mar 29, 2023 · 3 comments
Labels
Bug Something isn't working

Comments

@cleanylee
Copy link

cleanylee commented Mar 29, 2023

Describe the bug
cyto_plot will generate multiple density distribution plots in custom plot laytout when density_stack is set to 0

To Reproduce

Load required packages

library(CytoExploreR)
library(CytoExploreRData)

Load Activation GatingSet

gs <- cyto_load(
system.file(
"extdata/Activation-GatingSet",
package = "CytoExploreRData"
)
)

cyto_plot_custom(layout = c(2,2))

#cyto_plot will generate one plots if the density_stack!=0 (Normal)
cyto_plot(gs[29:30],
parent = "CD4 T Cells",
alias = "CD69+ CD4 T Cells",
channels = "CD69",
density_stack = 0.5,
title = "CD4 T Cells",
label_text = NA)

If the density_stack==0, then the cyto_plot will generate mutiple plots (Bug)

cyto_plot(gs[29:30],
parent = "CD4 T Cells",
alias = "CD69+ CD4 T Cells",
channels = "CD69",
density_stack = 0,
title = "CD4 T Cells",
label_text = NA)

Expected behavior
cyto_plot should generate only one plot when density_stack =0

Desktop (please complete the following information):

  • OS: [e.g. mac, windows or linux] Windows
@cleanylee cleanylee added the Bug Something isn't working label Mar 29, 2023
@cleanylee
Copy link
Author

screenshot

Rplot02

@cleanylee
Copy link
Author

There's no reply yet and the bug is still not fixed.
Just a short follow-up, and being curious about the status of CytoExploreR. I remember Dillon mentioning about version 2.0 quite some time before. Is there still any plan for an update of CytoExploreR? I am using CytoExploreR everyday. I do love this package and hope it can survive forever.

@DillonHammill
Copy link
Owner

DillonHammill commented Jun 22, 2023

@cleanylee this looks like the expected behaviour to me. Each sample will be placed in its own panel with any sub populations overlaid even when density_stack = 0. density_stack doesn't control the number of layers per plot only the degree of overlap between them. You could try setting density_layers = 1 as well to force a single layer per plot. Loads of exciting things are coming, stay tuned... CytoExploreR is definitely here to stay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants