Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(refactor): improve code readability in renderer #159

Merged
merged 4 commits into from
Nov 20, 2024
Merged

chore(refactor): improve code readability in renderer #159

merged 4 commits into from
Nov 20, 2024

Conversation

kokoISnoTarget
Copy link
Contributor

  • Renames element to node
  • Renames pos to box_position and content_position
  • Renames size to content_size
  • Adds an element fields to ElementCx which is of type ElementNodeData because we node.element_data().unwrap() 6 times
  • and move some code into their own functions (draw_text_input_text, draw_marker and draw_children)

nicoburns
nicoburns approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@nicoburns nicoburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me - thanks!

@nicoburns nicoburns merged commit d474223 into DioxusLabs:main Nov 20, 2024
8 checks passed
@kokoISnoTarget kokoISnoTarget deleted the small-renderer-improvements branch November 20, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoburns nicoburns nicoburns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kokoISnoTarget @nicoburns