Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new command sync options #806

Merged
merged 46 commits into from
Oct 26, 2022
Merged

feat: new command sync options #806

merged 46 commits into from
Oct 26, 2022

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Oct 17, 2022 •
edited
Loading

Summary

extracted/reimplemented from #666, this adds new command syncing behavior to make it easier for people to choose how they sync their commands.

closes #265
closes #433
closes #468

This is mostly untested.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes (not sure i got all of the docs about this)
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: enhancement New feature p: high High priority t: deprecation Deprecation of existing features labels Oct 17, 2022
@onerandomusername onerandomusername added this to the disnake v2.7 milestone Oct 17, 2022
@onerandomusername onerandomusername force-pushed the feat/command-sync branch 4 times, most recently from 31dbe23 to 1ea43ac Compare October 18, 2022 03:02
@onerandomusername onerandomusername changed the base branch from master to docs/bot-attributes October 18, 2022 03:03
@onerandomusername onerandomusername added the s: blocked Issue/PR is blocked by other issues label Oct 18, 2022
@onerandomusername onerandomusername force-pushed the feat/command-sync branch 3 times, most recently from e8ca0aa to 7683abc Compare October 18, 2022 18:02
Base automatically changed from docs/bot-attributes to master October 18, 2022 19:29
shiftinv
shiftinv reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't thoroughly tested it yet, this is still mainly a code review.

disnake/ext/commands/flags.py Outdated Show resolved Hide resolved
disnake/ext/commands/flags.py Outdated Show resolved Hide resolved
disnake/ext/commands/flags.py Outdated Show resolved Hide resolved
disnake/ext/commands/interaction_bot_base.py Show resolved Hide resolved
disnake/ext/commands/interaction_bot_base.py Outdated Show resolved Hide resolved
docs/ext/commands/additional_info.rst Show resolved Hide resolved
shiftinv
shiftinv reviewed Oct 25, 2022
View reviewed changes
disnake/ext/commands/flags.py Outdated Show resolved Hide resolved
disnake/ext/commands/flags.py Outdated Show resolved Hide resolved
disnake/ext/commands/interaction_bot_base.py Outdated Show resolved Hide resolved
disnake/ext/commands/interaction_bot_base.py Outdated Show resolved Hide resolved
@onerandomusername onerandomusername merged commit 6a9ce72 into master Oct 26, 2022
@onerandomusername onerandomusername deleted the feat/command-sync branch October 26, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EQUENOS EQUENOS EQUENOS approved these changes

@shiftinv shiftinv shiftinv approved these changes

@Sharp-Eyes Sharp-Eyes Awaiting requested review from Sharp-Eyes

Assignees
No one assigned
Labels
p: high High priority t: deprecation Deprecation of existing features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.7
3 participants
@onerandomusername @shiftinv @EQUENOS