Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for user-visible functions #39

Open
erex opened this issue Jun 6, 2018 · 3 comments
Open

Documentation for user-visible functions #39

erex opened this issue Jun 6, 2018 · 3 comments

Comments

@erex
Copy link
Member

erex commented Jun 6, 2018

@dill
It seems there are only three user-facing functions. This is the first challenge of the documentation; a neophyte is presented with a list of 35 entries in the help TOC. When first trying to get to grips, they don't know which of those doors to open.

Quick thoughts about documentation of those central functions

  • convert_project(): lacks an Example section, Details picks an odd topic to discuss (model names)
  • run_analysis(): does have an Example; again odd second paragraph of details
  • test_stats(): notes that results are "scaled, relative", perhaps describe what that means, could you not say proportional difference? Should tolerance argument and the last figure in Value section not be the same?
  • converted_distance_analyses: while not a function, is central to the user because this the product they will wish to manipulate. env is central to this--folks won't have used environments very much (I certainly haven't). I believe it is incorrect to say env only contains an obs.table object.

How do you want to proceed with changes to the documentation? Should I have a go and you can clean up after me?

@dill
Copy link
Contributor

dill commented Jun 7, 2018

Thanks for consolidating this @erex

I'd suggest that we flesh out the readdst-package help page and point to the three functions you mention here. I also suggest we cover the structure of the converted analysis object either there or in a separate help file, references in readdst-package.

Very happy for you to take a first run at it.

@erex
Copy link
Member Author

erex commented Jun 9, 2018

Above issue, partially addressed by 511e865 and 54429e8

@dill
Copy link
Contributor

dill commented Jun 11, 2018

Thanks for this Eric, these look good. 8f80fab re-reoxygens to update the .Rd files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants