Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warnings in Build and Deploy Process #1281

Open
bbengfort opened this issue Aug 21, 2022 · 0 comments
Open

Fix Warnings in Build and Deploy Process #1281

bbengfort opened this issue Aug 21, 2022 · 0 comments
Labels
level: expert deep knowledge of packages required priority: high should be done before next release type: task non-code related task

Comments

@bbengfort
Copy link
Member

bbengfort commented Aug 21, 2022

When we deployed v1.5 we received the following warnings and deprecation errors:

python setup.py sdist bdist_wheel
/Users/benjamin/.pyenv/versions/3.10.2/envs/yellowbrick/lib/python3.10/site-packages/setuptools/dist.py:717: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
  warnings.warn(
Warning: 'classifiers' should be a list, got type 'tuple'
Warning: 'keywords' should be a list, got type 'tuple'
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help
python setup.py register
/Users/benjamin/.pyenv/versions/3.10.2/envs/yellowbrick/lib/python3.10/site-packages/setuptools/dist.py:717: UserWarning: Usage of dash-separated 'description-file' will not be supported in future versions. Please use the underscore name 'description_file' instead
  warnings.warn(
Warning: 'classifiers' should be a list, got type 'tuple'
Warning: 'keywords' should be a list, got type 'tuple'
running register
running check
Registering yellowbrick to https://upload.pypi.org/legacy/
Server response (410): Project pre-registration is no longer required or supported, upload your files instead.
twine upload dist/*
Uploading distributions to https://upload.pypi.org/legacy/
Uploading yellowbrick-1.5-py3-none-any.whl
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 294.5/294.5 kB • 00:00 • 1.9 MB/s
Uploading yellowbrick-1.5.tar.gz
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 20.0/20.0 MB • 00:01 • 10.8 MB/s

View at:
https://pypi.org/project/yellowbrick/1.5/

Other notes:

  • update classifiers to Python 3.10
  • Check to make sure build/deploy is correct (e.g. the wheel build)
  • Update to API tokens instead of basic login:

During your recent upload or upload attempt of yellowbrick to PyPI, we noticed you used basic authentication (username & password). However, your account has two-factor authentication (2FA) enabled.

In the near future, PyPI will begin prohibiting uploads using basic authentication for accounts with two-factor authentication enabled. Instead, we will require API tokens to be used.

What should I do?

First, generate an API token for your account or project at https://pypi.org/manage/account/token/. Then, use this token when publishing instead of your username and password. See https://pypi.org/help/#apitoken for help using API tokens to publish.

@bbengfort bbengfort added priority: high should be done before next release level: expert deep knowledge of packages required type: task non-code related task labels Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level: expert deep knowledge of packages required priority: high should be done before next release type: task non-code related task
Projects
None yet
Development

No branches or pull requests

1 participant