-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caching to prevent unintentional rebuilds #88
Comments
Sorry to ping, but is any work planned on this? |
Nothing has been started to my knowledge but this is still a problem and should be addressed. Care to take a stab at a PR? |
Not sure I know this addon codebase that well to be honest. Also issue description lacks details of what is expected to be done and why/how this would help. I came back here (with some hope :) following a link in our codebase answering why we cannot have CSS hot reload and service workers together. |
@olegstepura we've been happy using #84 (comment) to have both. I don't really want service worker running in development anyway so I've just added that to a |
So if I read the PR comment linked above correctly, the inline strategy will cause the index.html file to be overwritten breaking hot reload. The suggestion is to only rewrite index.html when the strategy or contents of the registration script change to force a rewrite. Now that it's on my mind I'll do some research into a way to accomplish this. Suggestions welcome :) |
See: #86 (comment)
Also related: #84
The text was updated successfully, but these errors were encountered: