Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure existing babel options are preserved when compiling - fixes #133 #141

Closed
wants to merge 1 commit into from

Conversation

eshtadc
Copy link
Contributor

@eshtadc eshtadc commented Nov 6, 2018

Fixes #133 to enable existing babel configuration to be passed along. Still needs validation and tests.

@eshtadc
Copy link
Contributor Author

eshtadc commented Nov 6, 2018

Is compileModules still even needed? Seems that this applies only to ember-cli pre 2.12. Right now we still technically support that but once we move to babel 7 that means we drop support for <2.13. @marten-dockyard?

@eshtadc
Copy link
Contributor Author

eshtadc commented Nov 6, 2018

I don't think this PR is needed. See #133 (comment)

@eshtadc
Copy link
Contributor Author

eshtadc commented Dec 14, 2018

Doesn't appear to be the right thing to use application-level babel options when compiling this addons additional files.

@eshtadc eshtadc closed this Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant