From edb0fefa7fb12999e78f95099d7ad52e5f9c8f29 Mon Sep 17 00:00:00 2001
From: Frankie Yan <frankieyan@users.noreply.github.com>
Date: Wed, 23 Oct 2024 16:49:02 -0700
Subject: [PATCH] fix: Better alignment for Alert icons (#807)

* fix: Better alignment for Alert icons

* Update changelog

* Use IconButton in Alert

* Fix alignment when close button is not present
---
 CHANGELOG.md               | 1 +
 src/alert/alert.module.css | 9 ++++++++-
 src/alert/alert.tsx        | 7 +++++--
 3 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6f000c081..8138cfda0 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@ Reactist follows [semantic versioning](https://semver.org/) and doesn't introduc
 # Next
 
 -   [Feat] Expose `showTimeout` and `hideTimeout` props for `Tooltip`
+-   [Fix] The center alignment between the `Alert` component's icon and message is now more accurate when the message is only one-line long.
 
 # v26.0.0
 
diff --git a/src/alert/alert.module.css b/src/alert/alert.module.css
index d5b95121a..926df0f82 100644
--- a/src/alert/alert.module.css
+++ b/src/alert/alert.module.css
@@ -3,8 +3,15 @@
     border-width: 1px;
     color: var(--reactist-content-primary);
     padding: var(--reactist-spacing-small);
+}
+
+.content {
     /* this is to make sure it always has the same minimum height, whether it has a close button or not */
-    min-height: calc(2 * var(--reactist-spacing-small) + var(--reactist-button-small-height) + 2px);
+    min-height: var(--reactist-button-small-height);
+}
+
+.icon {
+    display: block;
 }
 
 .tone-info {
diff --git a/src/alert/alert.tsx b/src/alert/alert.tsx
index ccd00f5ef..bce2f8fc3 100644
--- a/src/alert/alert.tsx
+++ b/src/alert/alert.tsx
@@ -1,7 +1,7 @@
 import * as React from 'react'
 import { getClassNames } from '../utils/responsive-props'
 import { Box } from '../box'
-import { Button } from '../button'
+import { IconButton } from '../button'
 import { Columns, Column } from '../columns'
 
 import { AlertIcon } from '../icons/alert-icon'
@@ -41,13 +41,16 @@ function Alert({ id, children, tone, closeLabel, onClose }: AlertProps) {
                     <Box
                         paddingY="xsmall"
                         paddingRight={onClose != null && closeLabel != null ? undefined : 'small'}
+                        display="flex"
+                        alignItems="center"
+                        className={styles.content}
                     >
                         {children}
                     </Box>
                 </Column>
                 {onClose != null && closeLabel != null ? (
                     <Column width="content">
-                        <Button
+                        <IconButton
                             variant="quaternary"
                             size="small"
                             onClick={onClose}