Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Stop renovate from bumping engines or couple to .nvmrc updates #20

Open
henningmu opened this issue May 12, 2022 · 2 comments

Comments

@henningmu
Copy link
Contributor

I noticed a case where renovate would bump the engines.node field in package.json from 16.13 to 16.15, but not update the corresponding line in .nvmrc resulting in CI failures. Ideally, we would couple node updates to include both places. If that's not possible, we should disable node updates.

@rfgamaral do you happen to have a snippet for that, the docs have not to been super helpful, yet 😅

@rfgamaral
Copy link
Member

I noticed a case where renovate would bump the engines.node field in package.json from 16.13 to 16.15, but not update the corresponding line in .nvmrc resulting in CI failures.

That's strange. The value in .nvmrc (i.e. v16) should allow any v16.x version to work. And that's the whole point actually, to not force us to update to every minor Node.js version all the time, it should just work. Are you sure this is the problem we are facing? Can you link me to one of those CI fails?

If that's not possible, we should disable node updates.

Either way, I would probably go with this anyway. I feel like updating Node to major versions should be something that we do manually, and in a coordinated fashion, so that everyone in the team is aware of this change, and can plan to update their Nodejs version locally.

@proxi
Copy link
Member

proxi commented May 12, 2022

That is something I also noticed and reported, e.g. here so I don't think it's Frontend-only. Apart from package.json and .nvmrc there are also Dockerfiles, workflow files using explicit version syntax, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants