Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still throwing exceptions. #163

Closed
mattbrownfaro opened this issue Sep 6, 2023 · 2 comments · Fixed by #165
Closed

Still throwing exceptions. #163

mattbrownfaro opened this issue Sep 6, 2023 · 2 comments · Fixed by #165
Labels
bug Something isn't working

Comments

@mattbrownfaro
Copy link

mattbrownfaro commented Sep 6, 2023

Hi @DomCR,

Looking MUCH better but missing objects. And throwing exceptions. ALFA Sportwagon-4 views.zip
Snag_2104073d
Missing wheels and other views of the car, but geometry looks great.

This drawing is throwing a lot of exceptions. I believe it loaded in a previous ACADSharp version
2140QUEENCITY.zip

Built DxfWriter-Full-refactor branch

Would you be interested in a development contract? We'd like to use this library in our fall release. It's close but still can't load a bunch of drawings that our current DWG library can. Please contact me at [email protected] if interested.

Thanks Dom!

Originally posted by @mattbrownfaro in #142 (comment)

@DomCR
Copy link
Owner

DomCR commented Sep 11, 2023

Hi @mattbrownfaro

The branch DxfWriter-Full-refactor is currently in development, all the exceptions are expected, when the task is completed and merge this should work fine the ALFA Sportwagon-4 views file.

About the 2140QUEENCITY is more complicated, the dxf writer that they used encoded the name of the model space in a funny way $MODEL_SPACE which messes up the way that ACadShrap finds it.

About the missing wheels, it seems that they are drawn with polylines, for some reason the ones that the writer is generating are not valid.

I'll open 2 branches to take a look to both issues.

@DomCR DomCR added the bug Something isn't working label Sep 11, 2023
@DomCR DomCR mentioned this issue Sep 11, 2023
4 tasks
@DomCR DomCR linked a pull request Sep 21, 2023 that will close this issue
@DomCR
Copy link
Owner

DomCR commented Oct 27, 2023

This issue seems to be bigger than I expected, the file that is failing is because is in an older version AC1009 which is not supported by ACadSharp at the moment, by now I'll add an exception to the writer to indicate that this version is not supported but it will take time do make the DxfReader compatible with it.

@DomCR DomCR closed this as completed in #165 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants