Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remapped inputs #122

Closed
wants to merge 1 commit into from
Closed

Remapped inputs #122

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2017

Left player:
	Keyboard
		Up		- up
		Down		- down
		Right Ctrl	- pull
		Enter		- power

	Joystick 2 (360 controller)
		Left analog	- up / down
		B		- pull
		X		- power

Right player:
	Keyboard
		W		- up
		S		- down
		Space		- pull
		Left Ctrl	- power

	Joystick 1 (360 controller)
		Left analog	- up / down
		B		- pull
		X		- power

@fragmental
Copy link
Contributor

What about flippers?

@Cheeseness
Copy link
Contributor

Thinking about this more, I'm leaning towards having the player "hit" or "pull" or whatever we're calling it key control both flippers. That keeps the control scheme simple and concise.

Until #107 is resolved, flippers don't exist in 87% of the game (2 out of 3 variants don't have them and 4 out of 5 tables don't use them). I think fixating on them at this point to an extent that it's making it hard to make decisions about core gameplay isn't worthwhile.

@fragmental
Copy link
Contributor

Does hit or pull actually do something in game, besides the animation?

#127 on flippers. addresses buttons somewhat.

@Cheeseness
Copy link
Contributor

Hit or pull is cosmetic for now. I'm leaning towards feeling that it's best as a cosmetic thing and should be done automatically to coincide with paddle collisions rather than impact the ball, but I know people are inclined to explore that and it might end up being fun.

I don't see #127 being resolved before our "end of AF" milestone, so I'm going to go ahead with a single button doing the hit animation and both flippers for now. We can adjust that down the road as part of the ongoing discussion in #115

@fragmental
Copy link
Contributor

@Cheeseness that's acceptable.

My thoughts on hit/pull is that it should be more than cosmetic, unless there was one button as a sort of "taunt". I guess triggering flippers would sort of make it coincide with an action, even if those actions are sort of unrelated.

@Cheeseness
Copy link
Contributor

Yeah, that's my thought for the short term. Looking forward to seeing stuff expanded upon though!

@fragmental
Copy link
Contributor

fragmental commented Apr 27, 2017

@Cheeseness I think it should be fine to leave joystick control the way it is, though.

edit: for flippers

@Cheeseness
Copy link
Contributor

@fragmental Joystick controls need at least some changes. Powers aren't bound to anything right now, and so far as I can tell, neither are flippers.

OK, I'm testing this now, and I'm not sure that flipping left and right controls on the keyboard is a good idea (up and down needs to be right player, W and S needs to be left player).

I think for the sake of making it easier for me to pull all this together, I'm going to close this PR and implement changes off the current head.

@Cheeseness Cheeseness closed this Apr 27, 2017
@fragmental
Copy link
Contributor

fragmental commented Apr 27, 2017 via email

@Cheeseness
Copy link
Contributor

Yeah, let's not get excited about what things should and shouldn't be. There have been lots of changes since you last worked on this stuff, and it's better to check the current versions of files in the repo than make assumptions about what the problems are.

@Cheeseness Cheeseness mentioned this pull request Apr 27, 2017
@ghost ghost deleted the remap-inputs branch April 27, 2017 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants