-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remapped inputs #122
Remapped inputs #122
Conversation
ghost
commented
Apr 26, 2017
•
edited by ghost
Loading
edited by ghost
What about flippers? |
Thinking about this more, I'm leaning towards having the player "hit" or "pull" or whatever we're calling it key control both flippers. That keeps the control scheme simple and concise. Until #107 is resolved, flippers don't exist in 87% of the game (2 out of 3 variants don't have them and 4 out of 5 tables don't use them). I think fixating on them at this point to an extent that it's making it hard to make decisions about core gameplay isn't worthwhile. |
Does hit or pull actually do something in game, besides the animation? #127 on flippers. addresses buttons somewhat. |
Hit or pull is cosmetic for now. I'm leaning towards feeling that it's best as a cosmetic thing and should be done automatically to coincide with paddle collisions rather than impact the ball, but I know people are inclined to explore that and it might end up being fun. I don't see #127 being resolved before our "end of AF" milestone, so I'm going to go ahead with a single button doing the hit animation and both flippers for now. We can adjust that down the road as part of the ongoing discussion in #115 |
@Cheeseness that's acceptable. My thoughts on hit/pull is that it should be more than cosmetic, unless there was one button as a sort of "taunt". I guess triggering flippers would sort of make it coincide with an action, even if those actions are sort of unrelated. |
Yeah, that's my thought for the short term. Looking forward to seeing stuff expanded upon though! |
@Cheeseness I think it should be fine to leave joystick control the way it is, though. edit: for flippers |
@fragmental Joystick controls need at least some changes. Powers aren't bound to anything right now, and so far as I can tell, neither are flippers. OK, I'm testing this now, and I'm not sure that flipping left and right controls on the keyboard is a good idea (up and down needs to be right player, W and S needs to be left player). I think for the sake of making it easier for me to pull all this together, I'm going to close this PR and implement changes off the current head. |
They should mapped to something unless someone unmapped them. See #78
…On Apr 26, 2017 11:29 PM, "Cheeseness" ***@***.***> wrote:
Closed #122 <#122>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#122 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE1A8LTyX7vW7Hu9DMSvWOeK0oUqMe-yks5r0At5gaJpZM4NJe_S>
.
|
Yeah, let's not get excited about what things should and shouldn't be. There have been lots of changes since you last worked on this stuff, and it's better to check the current versions of files in the repo than make assumptions about what the problems are. |