Dr b s patch 8 #33
Merged
Dr b s patch 8 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added quay.io login for push to quay.io
Removed typo
DrB-S
commented
Jan 3, 2024
Added quay.io/stevebs/ in front of heatcluster.
erinyoung
reviewed
Jan 4, 2024
| @@ -19,8 +19,12 @@ jobs: | |||
| env: | |||
There was a problem hiding this comment.
Lines 18-27 (your Docker login step) might not work, or maybe it might. I know there's a lot of ways to do this.
This is how I log into quay:
- name: Login to Quay
uses: docker/login-action@v2
with:
registry: quay.io
username: ${{ secrets.QUAY_USERNAME }}
password: ${{ secrets.QUAY_PASSWORD }}
erinyoung
reviewed
Jan 4, 2024
.github/workflows/docker.yml
Outdated
| @@ -30,14 +34,14 @@ jobs: | |||
| id: buildx | |||
| uses: docker/setup-buildx-action@v2 | |||
|
|
|||
| - name: Build and push to <insert repo> | |||
| - name: Build and push to quay.io/stevebs/heatcluster | |||
There was a problem hiding this comment.
I think you have a typo here
Your repository name is quay.io/stevebs22/heatcluster (https://quay.io/repository/stevebs22/heatcluster)
erinyoung
reviewed
Jan 4, 2024
.github/workflows/docker.yml
Outdated
| uses: docker/build-push-action@v3 | ||
| with: | ||
| file: Dockerfile | ||
| build-args: HEATCLUSTER_VER=${{ github.event.inputs.version }} | ||
| push: true | ||
| target: app | ||
| tags: heatcluster:${{ github.event.inputs.version }} | ||
| tags: quay.io/stevebs/heatcluster:${{ github.event.inputs.version }} |
There was a problem hiding this comment.
See comment above (I think there is a typo here)
erinyoung
reviewed
Jan 4, 2024
.github/workflows/docker.yml
Outdated
| @@ -46,4 +50,4 @@ jobs: | |||
| build-args: HEATCLUSTER_VER=${{ github.event.inputs.version }} | |||
| push: true | |||
| target: app | |||
| tags: heatcluster:latest | |||
| tags: quay.io/stevebs/heatcluster:latest | |||
There was a problem hiding this comment.
See comment above (I think there is a typo here)
|
Did you set up a robot account for quay? It will need access to your heatcluster repo with write access. |
Corrected quay.io username (stevebs -> stevebs22) and added quay.io login.
|
I have corrected docker.yml |
|
Setting up the quay robot account now. |
|
Robot account is set up. |
erinyoung
approved these changes
Jan 4, 2024
|
Thanks for ALL your help!
The latest (v1.0.2c-2024-01-04) is successfully pushed to quay.io.
Stephen M. Beckstrom-Sternberg, PhD
Bioinformatics Contractor
Arizona State Public Health Lab
Arizona Department of Health Services
Cell: (602) 653-5011
Email: ***@***.***
… On Jan 4, 2024, at 11:17 AM, Young ***@***.***> wrote:
@erinyoung approved this pull request.
Awesome!
I vote you merge this and test it.
—
Reply to this email directly, view it on GitHub <#33 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVTVLJUJRZFBJKG5JKJPYSLYM3W3FAVCNFSM6AAAAABBMB2GOKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBUG42DAOBVGQ>.
You are receiving this because you modified the open/close state.
--
CONFIDENTIALITY NOTICE: This e-mail is the property of the Arizona
Department of Health Services and contains information that may be
PRIVILEGED, CONFIDENTIAL, or otherwise exempt from disclosure by applicable
law. It is intended only for the person(s) to whom it is addressed. If
you have received this communication in error, please do not retain or
distribute it. Please notify the sender immediately by e-mail at the
address shown above and delete the original message. Thank you.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Quay.io github secrets and login info.