Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: inconsistency in terms of "send" #211

Open
1 of 2 tasks
maximilianpilz opened this issue Jul 20, 2023 · 1 comment
Open
1 of 2 tasks

bug: inconsistency in terms of "send" #211

maximilianpilz opened this issue Jul 20, 2023 · 1 comment
Labels
bug Something isn't working v1 Version 1 is affected v2 Version 2 is affected

Comments

@maximilianpilz
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

sdc11073 is inconsistent in terms of the term "send", on the one hand on the client side it treats a message as not send if no response has been received from the http server and tries sending it again, on the other hand on the server side it calls the registered callbacks independent of whether a response was send or can be send. sdc11073 should only handle those messages for which it could send a response or should not send again if it could deliver the request bytes, but didn't receive a response

Expected Behavior

consistent client and server implementations

Minimal Reproducible Example

No response

Solution proposal

No response

Python Version

3.11.4

Operating system

"win32" and "linux"

Sdc11073 Version

1.1.28

Link to sdc11073 Logs

No response

Further Information

No response

Participation

  • I am willing to submit a pull request to fix this bug.
@maximilianpilz maximilianpilz added the bug Something isn't working label Jul 20, 2023
@maximilianpilz
Copy link
Collaborator Author

maximilianpilz commented Jul 20, 2023

Just to give an example of why this might be a practical issue:

MdibVersion X arrives via an HTTP request, but no response is given or the response gets dropped, then the MdibVersion X arrives again due to the retry mechanism. From the perspective of the client it was "send" only once, due to no response for the first one, but from the persepctive of the server it was "send" twice actually, which then might result in an error, because it is not allowed for reports other than DescriptionModificationReports.

@maximilianpilz maximilianpilz added v1 Version 1 is affected v2 Version 2 is affected labels Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v1 Version 1 is affected v2 Version 2 is affected
Projects
None yet
Development

No branches or pull requests

1 participant