bug: consumer tries to subscribe even if there are no actions to subscribe to

[leon1995]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

sdc11073/src/sdc11073/sdcclient/sdcclientimpl.py

Line 412 in c3e989a

self._subscribe(dpwsHosted, subscribe_actions,

there is no check that subscribe_actions is not empty

Expected Behavior

not sending a subscribe request with empty actions

Minimal Reproducible Example

No response

Solution proposal

No response

Python Version

3.10.11

Operating system

win

Sdc11073 Version

1.3.2

Link to sdc11073 Logs

No response

Further Information

2024-11-22 10:47:49.937234 RUNNER sdc.client.subscr      INFO    c0### startSubscription "" ###
2024-11-22 10:47:49.950232 RUNNER sdc.client.soap        ERROR   c0subscribe : POST to netloc='192.168.0.10:52277' path='/cb3a5239-cd2c-4ef9-9ca9-870218e9dbde/set/': could not send request, HTTP response=400
content='b'<?xml version="1.0" encoding="UTF-8"?>\n<SOAP-ENV:Envelope xmlns:SOAP-ENV="http://www.w3.org/2003/05/soap-envelope" xmlns:SOAP-ENC="http://www.w3.org/2003/05/soap-encoding" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:pm="http://standards.ieee.org/downloads/11073/11073-10207-2017/participant" xmlns:dpws="http://docs.oasis-open.org/ws-dd/ns/dpws/2009/01" xmlns:si="http://standards.ieee.org/downloads/11073/11073-20702-2016" xmlns:wsa5="http://www.w3.org/2005/08/addressing" xmlns:ext="http://standards.ieee.org/downloads/11073/11073-10207-2017/extension" xmlns:adtm="urn:oid:1.3.6.1.4.1.3592.2.6933.6.1" xmlns:adts="urn:oid:1.3.6.1.4.1.3592.2.6934.2.1" xmlns:srv="http://standards.ieee.org/downloads/11073/11073-20701-2018" xmlns:msg="http://standards.ieee.org/downloads/11073/11073-10207-2017/message" xmlns:wsd11="http://docs.oasis-open.org/ws-dd/ns/discovery/2009/01" xmlns:wse4="http://schemas.xmlsoap.org/ws/2004/08/eventing" xmlns:wst4="http://schemas.xmlsoap.org/ws/2004/09/transfer" xmlns:wsx4="http://schemas.xmlsoap.org/ws/2004/09/mex"><SOAP-ENV:Header><wsa5:RelatesTo>urn:uuid:a73b3584-0dd3-4ce0-bb34-d9ec03b29e97</wsa5:RelatesTo><wsa5:Action SOAP-ENV:mustUnderstand="true">http://www.w3.org/2005/08/addressing/soap/fault</wsa5:Action></SOAP-ENV:Header><SOAP-ENV:Body><SOAP-ENV:Fault><SOAP-ENV:Code><SOAP-ENV:Value>SOAP-ENV:Sender</SOAP-ENV:Value><SOAP-ENV:Subcode><SOAP-ENV:Value>dpws:FilterActionNotSupported</SOAP-ENV:Value></SOAP-ENV:Subcode></SOAP-ENV:Code><SOAP-ENV:Reason><SOAP-ENV:Text xml:lang="en">no notifications match the supplied filter (no action given at all)</SOAP-ENV:Text></SOAP-ENV:Reason><SOAP-ENV:Detail></SOAP-ENV:Detail></SOAP-ENV:Fault></SOAP-ENV:Body></SOAP-ENV:Envelope>\r\n''
2024-11-22 10:47:49.951234 RUNNER sdc.client.subscr      ERROR   c0could not subscribe: HTTPReturnCodeError(status=400, reason=ReceivedSoapFault(code="SOAP-ENV:Sender", subcode="dpws:FilterActionNotSupported", reason="no notifications match the supplied filter (no action given at all)", detail=""))

Participation

• I am willing to submit a pull request to fix this bug.