Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphics.c does not clip #358

Open
rasky opened this issue Mar 4, 2023 · 0 comments
Open

graphics.c does not clip #358

rasky opened this issue Mar 4, 2023 · 0 comments

Comments

@rasky
Copy link
Collaborator

rasky commented Mar 4, 2023

graphics.c does not perform any clipping, which means that it's possible to make the application crash by writing outside the target surface.

Following the current libdragon approach, I think it would be useful to implement some clipping on the surface extents. This could be easily done within the __set_pixel macro at the expense of some performance, or better done function by function before entering the per-pixel loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant