Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for SessionList #594

Closed
takahirom opened this issue Jan 25, 2020 · 6 comments · Fixed by #720
Closed

Add unit tests for SessionList #594

takahirom opened this issue Jan 25, 2020 · 6 comments · Fixed by #720
Assignees
@shiraji
Labels
welcome contribute

Comments

@takahirom
Copy link
Member

Kind (Required)

  • Improvement

Overview (Required)

  • That class contains many logics!

Links
@takahirom takahirom changed the title Add tests for SessionList Add unnit tests for SessionList Jan 25, 2020
@takahirom takahirom changed the title Add unnit tests for SessionList Add unit tests for SessionList Jan 25, 2020
@a25max
Copy link
Contributor

a25max commented Jan 25, 2020

I want to try it

@takahirom
Copy link
Member Author

Thanks! Assigned 🙏

@a25max
Copy link
Contributor

a25max commented Jan 29, 2020

Sorry, Give up 😢

@roana0229
Copy link
Contributor

No problem 😄

@shiraji
Copy link
Contributor

shiraji commented Feb 5, 2020

It seems no one is working on this one. Can I grab this issue?

@takahirom
Copy link
Member Author

Thanks! Assigned 👍

@takahirom takahirom assigned shiraji and unassigned a25max Feb 5, 2020
@shiraji shiraji mentioned this issue Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shiraji shiraji

Labels
welcome contribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SessionListTest shiraji/conference-app-2020
4 participants
@takahirom @shiraji @roana0229 @a25max