-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Level filter does not work correctly? #709
Comments
Probably we should implement level filter🙏 |
@takahirom |
Thanks! Assigned!🙏 |
I think we should have list. Not forBeginer field. |
I see. |
初心者向け、中級者、上級者だった気がします🙏 |
理解です。 |
あってます。ありがとうございます😂 |
Overview (Required)
I think FiltersTest does not pass correctly.
Because the data class Session has no member "forBeginners" but the test checks this parameter.
Additionally, data class has the member "intendedAudience", but the actual response doesn't have that.
SessionEntity's intendedAudience value is always null.
And also, the Filters#isPass() method does not check audience categories.
I think this app's audience filter function is not working.
Both in day1 and day2, the results are the same with or without the level filters.
Steps To Reproduce
Expected behavior
Filter sessions by audience categories.
Screenshots
Env:
Additional context
I found this problem when researching #614 . But this issue is more deep-seated than I thought, so I divided.
The text was updated successfully, but these errors were encountered: