Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level filter does not work correctly? #709

Closed
clockvoid opened this issue Feb 3, 2020 · 8 comments · Fixed by #711
Closed

Level filter does not work correctly? #709

clockvoid opened this issue Feb 3, 2020 · 8 comments · Fixed by #711
Labels
bug Something isn't working welcome contribute

Comments

@clockvoid
Copy link
Contributor

clockvoid commented Feb 3, 2020

Overview (Required)
I think FiltersTest does not pass correctly.
Because the data class Session has no member "forBeginners" but the test checks this parameter.
Additionally, data class has the member "intendedAudience", but the actual response doesn't have that.
SessionEntity's intendedAudience value is always null.
And also, the Filters#isPass() method does not check audience categories.
I think this app's audience filter function is not working.
Both in day1 and day2, the results are the same with or without the level filters.

Steps To Reproduce

  1. Go to top
  2. Click on level filters
  3. See Applicable session number

Expected behavior
Filter sessions by audience categories.

Screenshots

beginners both level
day1
day2

Env:

  • Device: Pixel 4
  • OS: 10
  • App Version or the branch: 1.2.0 on c4661b2 (latest master branch)

Additional context
I found this problem when researching #614 . But this issue is more deep-seated than I thought, so I divided.

@clockvoid clockvoid added the bug Something isn't working label Feb 3, 2020
@clockvoid clockvoid changed the title Level filter is not work correctly? Level filter does not work correctly? Feb 3, 2020
@takahirom
Copy link
Member

takahirom commented Feb 4, 2020

Probably we should implement level filter🙏

@clockvoid
Copy link
Contributor Author

@takahirom
Thank you for your replying.
I want to implement it.
I will implement it like 2019 version app to pass the FiltersTest.

@takahirom
Copy link
Member

Thanks! Assigned!🙏

@takahirom
Copy link
Member

I think we should have list. Not forBeginer field.
forBeginnerのようなフィールドではなく、レベルをリストで持ってるような構造にする必要がありそうです🙏

@clockvoid
Copy link
Contributor Author

clockvoid commented Feb 4, 2020

I see.
We can see the list of level in timetable response.
In this response, the level Array has three elements, but the app's filter has two. What is the third element?
すみません、日本語で失礼します。
レスポンスを見るとリストで持っていますね...
3つ要素があるようですが、アプリのフィルターは2つしか持ってないです。これ3つめは何なんですかね...?

@takahirom
Copy link
Member

初心者向け、中級者、上級者だった気がします🙏

@clockvoid
Copy link
Contributor Author

理解です。
多分これアプリ側のフィルターとしても全部必要かと思いますので、そこも含めてやっちゃいます

@takahirom
Copy link
Member

あってます。ありがとうございます😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working welcome contribute
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants