Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SessionListTest #720

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

shiraji
Copy link
Contributor

@shiraji shiraji commented Feb 5, 2020

Issue

Overview (Required)

  • Add test cases for SessionList
  • Since I didn't know much of SessionList, I created test cases based on actual code. Please point out if there are test cases that are unnecessary.

Links

N/A

Screenshot

N/A

@takahirom
Copy link
Member

Thank you as always!
This time it's okay because it doesn't run on Android, but I avoided using white space in method names because Android doesn't support spaces.
What do you think?
https://discuss.kotlinlang.org/t/android-issue-with-backticked-method-names/66

@shiraji
Copy link
Contributor Author

shiraji commented Feb 5, 2020

how about replacing spaces with _ ?

@takahirom
Copy link
Member

I also like spaces, but please replace them with underbars this time.🙏

@shiraji
Copy link
Contributor Author

shiraji commented Feb 5, 2020

sure!

@shiraji shiraji force-pushed the shiraji/add-sessionlist-tests branch from 1b5f4d2 to d517175 Compare February 5, 2020 13:26
@shiraji
Copy link
Contributor Author

shiraji commented Feb 5, 2020

Fixed them and squash commits.

@shiraji shiraji force-pushed the shiraji/add-sessionlist-tests branch from d517175 to b1bfc26 Compare February 5, 2020 14:05
@jmatsu-bot
Copy link
Collaborator

Your apk has been deployed to https://deploygate.com/distributions/8267dd4377668adf642ffe942934b686e8ea3d23. Anyone can try your changes via the link.

Generated by 🚫 Danger

@jmatsu-bot
Copy link
Collaborator

No issue was reported. Cool!

Generated by 🚫 Danger

@takahirom
Copy link
Member

LGTM! Thank you for contribution!🙏

@takahirom takahirom merged commit d0662b6 into DroidKaigi:master Feb 5, 2020
@shiraji shiraji deleted the shiraji/add-sessionlist-tests branch February 5, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unit tests for SessionList
3 participants