Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Split the Build action into several actions #42

Closed
tomoya0x00 opened this issue Apr 18, 2023 · 3 comments · Fixed by #51
Closed

[Build] Split the Build action into several actions #42

tomoya0x00 opened this issue Apr 18, 2023 · 3 comments · Fixed by #51
Assignees

Comments

@tomoya0x00
Copy link
Contributor

In the conference-app-2022, the Build action time is reached 53m eventually.

DroidKaigi/conference-app-2022#647

image

It would be appreciated if to avoid such a long action time. doesn't it?

We can improve total action time by splitting the Build action into several actions.

like this:

  • assemble & upload aab to somewhere
  • spotlessCheck
  • lint
  • local unit tests & report the result

First of all, I think it is good to split assemble & upload aab to somewhere and another.
Ideally, however, lint and local unit tests should run even if spotlessCheck fails. This is because it is ideal to detect all errors at once and show them to the contributors.

@jmatsu
Copy link
Contributor

jmatsu commented Apr 18, 2023

Which task was heaviest?

@tomoya0x00
Copy link
Contributor Author

It was . /gradlew assemble -stacktrace, then . /gradlew lintDebug -stacktrace and . /gradlew spotlessCheck -stacktrace.

The log of a successful Build Action could not be viewed because the retention period had expired.

However, the following Build Action cancels the local unit tests in the middle, but it may be helpful

https://github.com/DroidKaigi/conference-app-2022/actions/runs/4036987728/jobs/6939968810

image

@jmatsu jmatsu linked a pull request Apr 25, 2023 that will close this issue
1 task
@jmatsu
Copy link
Contributor

jmatsu commented Apr 25, 2023

Done. Build workflow must be improved.

@jmatsu jmatsu closed this as completed Apr 25, 2023
@jmatsu jmatsu self-assigned this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants