Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement building with custom HYPRLAND_HEADERS environment variable #145

Open
iddm opened this issue Dec 18, 2024 · 5 comments · May be fixed by #147
Open

Implement building with custom HYPRLAND_HEADERS environment variable #145

iddm opened this issue Dec 18, 2024 · 5 comments · May be fixed by #147
Assignees
Labels
enhancement New feature or request

Comments

@iddm
Copy link

iddm commented Dec 18, 2024

Hi, thanks for the great plugin!

Unfortunately, can't build it from the main branch right now:

src/main.cpp:21:7: error: ‘CHyprColor’ does not name a type; did you mean ‘CHyprError’?
   21 | const CHyprColor s_pluginColor = {0x61 / 255.0F, 0xAF / 255.0F, 0xEF / 255.0F, 1.0F};
      |       ^~~~~~~~~~
      |       CHyprError
src/main.cpp: In function ‘void raiseNotification(const std::string&, float)’:
src/main.cpp:39:56: error: ‘s_pluginColor’ was not declared in this scope
   39 |         HyprlandAPI::addNotification(PHANDLE, message, s_pluginColor, timeout);
      |                                                        ^~~~~~~~~~~~~
src/main.cpp: In function ‘const std::string& getWorkspaceFromMonitor(const PHLMONITOR&, const std::string&)’:
src/main.cpp:74:58: error: ‘class CWorkspace’ has no member named ‘getWindows’
   74 |             if (workspacePtr == nullptr || workspacePtr->getWindows() == 0) {
      |                                                          ^~~~~~~~~~
make: *** [Makefile:38: split-monitor-workspaces.so] Error 1
@iddm iddm closed this as completed Dec 18, 2024
@iddm
Copy link
Author

iddm commented Dec 18, 2024

Figured I have an old code for some reason.

@iddm iddm reopened this Dec 18, 2024
@iddm
Copy link
Author

iddm commented Dec 18, 2024

No, actually, I just updated my Hyprland repo, checked that the wanted type is there CHyprColor in src/helpers/Color.hpp, exported the env variable to point to the Hyprland repository root directory, but still the plugin refuses, it seems, to accept the provided HYPRLAND_HEADERS path.

@iddm
Copy link
Author

iddm commented Dec 18, 2024

I see no use of it within the Makefile at all, so I guess, it should be removed from the README file or should be put back to use. If I pollute my system with the pkgconfig file and the headers, the build finishes just fine, however, I'd prefer to simply let it find the headers using the mentioned environment variable.

@zjeffer
Copy link
Collaborator

zjeffer commented Dec 18, 2024

I see the HYPRLAND_HEADERS support was removed in this commit (5d13b75) for some reason, not sure why.
You can perhaps revert part of that commit and see if that works. PRs welcome ;)

@zjeffer zjeffer added the build error The plugin couldn't be built property label Dec 19, 2024
@zjeffer zjeffer self-assigned this Dec 19, 2024
@zjeffer
Copy link
Collaborator

zjeffer commented Dec 19, 2024

@iddm Can you test if #147 works for you?

@zjeffer zjeffer linked a pull request Dec 19, 2024 that will close this issue
@zjeffer zjeffer changed the title Can't build the plugin Implement building with custom HYPRLAND_HEADERS environment variable Jan 2, 2025
@zjeffer zjeffer added enhancement New feature or request and removed build error The plugin couldn't be built property labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants