-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and publish #8
Comments
Hi @Dzarda7 Sure.. I will look at any pull request. And if there are no issues I will merge! Thanks for your work on this! |
And will you publish it into library manager of arduino and PlatformIO? Thanks. |
Just checked out this project and asked myself the same question 😄 Glad I don't need to create an issue (and PR as you already raised #9). |
@marcelstoer Lol... it always helps checking other issues 😉 @Dzarda7 I don't know if I can push it in to the PlatformIO and Arduino manager, because there are already a a few and I used soms Adafruit code. I did credit them in the library but I don't know how this works publishing. I will figure this out. Furthermore, I am really busy atm, so things might move slowly, but that is a time-management thingy on my edit 😄 |
Thank you Dustin. It should be ok to publish it in my opinion, because all of it is under MIT licence. I can definitely understand that time management problem 😃. Please do that when you find some time and let me know I would really appreciate it. |
That's right, but...
|
@marcelstoer Yes. The reason is that this library is part of a much bigger project FreeTouchDeck and this way I could fix and have control over most libraries used in that project. |
@DustinWatts #9 adds How to publish the library:
Once #9 is merged the project is pretty much ready for submission. It won't take long. |
Just adding to what's said above - thanks for the library, and it would be amazing if it were published to the PlatformIO registry. |
Hello, first of all, thank you for this library. I forked it and found that it is also compatible with FT5436, so I just added chip IDs and made it compatible with both. I also added rotation functionality. It would be awesome if it will be in arduino library manager and PlatformIO libraries. If I open pull request, will you do it please? Else I can do it with my fork.
Thank you so much.
The text was updated successfully, but these errors were encountered: