Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builtin:logmonitoring.log-storage-settings to CR and reconciler #4053

Merged
merged 21 commits into from
Nov 25, 2024
Merged

Add builtin:logmonitoring.log-storage-settings to CR and reconciler #4053

merged 21 commits into from
Nov 25, 2024

Commits on Nov 13, 2024

  1. Add IngestRuleMatchers to CR

    @waodim
    waodim committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    82eab51 View commit details
    Browse the repository at this point in the history

  2. Add client logic for builtin:logmonitoring.log-storage-settings schema

    @waodim
    waodim committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3027f1f View commit details
    Browse the repository at this point in the history

  3. Add logic to reconciler and add condition

    @waodim
    waodim committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    6cc9fad View commit details
    Browse the repository at this point in the history

  4. Run mockery to generate mocks

    @waodim
    waodim committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bde9ad7 View commit details
    Browse the repository at this point in the history

  5. Fix linting

    @waodim
    waodim committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    72e0aab View commit details
    Browse the repository at this point in the history

  6. Export client logic in reconciler to own function

    @waodim
    waodim committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a4767e4 View commit details
    Browse the repository at this point in the history

  7. Fix linting by excluding dupl linter in the 'perform' methods 

    The methods are pretty similar, that is true, but they still differ in the parameters, hence I decided to exclude the dupl linter for both methods
    @waodim
    waodim committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    13e26a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Change maxDescLen because it was too large

    @waodim
    waodim committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    17e84f8 View commit details
    Browse the repository at this point in the history

  2. Make naming private and more precise

    @waodim
    waodim committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    98b8685 View commit details
    Browse the repository at this point in the history

  3. Make naming more consistent

    @waodim
    waodim committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    5a09114 View commit details
    Browse the repository at this point in the history

  4. Make schemaID not public and rerun mockery

    @waodim
    waodim committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6a09f0c View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Apply feedback from review 

    Outsourced logmon settings check to its own reconciler; Built in a check that checks if the condition, that there are already settings are outdated, to not pollute logs too much; added test
    @waodim
    waodim committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c8d6905 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/add-ingestrulematchers

    @waodim
    waodim authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e499de8 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. Merge branch 'main' into feature/add-ingestrulematchers

    @waodim
    waodim authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    2c76f1a View commit details
    Browse the repository at this point in the history

  2. Refactor TotalCount check, add condition removal

    @waodim
    waodim committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    15ba04c View commit details
    Browse the repository at this point in the history

  3. Apply feedback

    @waodim
    waodim committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    13961d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Return in case lm is not enabled, move log message

    @waodim
    waodim committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    2320f89 View commit details
    Browse the repository at this point in the history

  2. Fix linting

    @waodim
    waodim committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0070bb8 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary if condition

    @waodim
    waodim committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9d32839 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Merge branch 'main' into feature/add-ingestrulematchers

    @waodim
    waodim authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    bac6d41 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feature/add-ingestrulematchers

    @waodim
    waodim authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9ed8f4d View commit details
    Browse the repository at this point in the history