Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two levels up #1

Open
robsonsobral opened this issue Nov 9, 2014 · 2 comments
Open

Two levels up #1

robsonsobral opened this issue Nov 9, 2014 · 2 comments

Comments

@robsonsobral
Copy link

Hi!

I'm sorry for being the first to bother you.

Why not to put the directory .env two levels up, instead of inside system\expressionengine? It could be one less thing to bother us on update.

Thanks for the attention and for the Manifest.

@bryannielsen
Copy link
Contributor

Hi @robsonsobral!

Thanks for taking a look at Manifest and giving your feedback, it's always appreciated :-)

You're the second person to mention this and I think it makes complete sense. So we're going to make the path configurable. The reason for using system/expressionengine is because the global APPPATH variable is one of the few reliable system path var's available so early in the process.

We also didn't want to assume that everyone is using the default system/expressionengine value as their APPPATH and load the .env from two levels above that. But it seems the best approach will be to use APPPATH as the default and allow each install to decide where the .env file should live.

Thanks again for your interest!

@robsonsobral
Copy link
Author

Thanks for your attention!

If every thing we don't need to update on eecms was a sibling directory or file of the BASEPATH, the life will be simpler.

Thanks for think about it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants