-
Notifications
You must be signed in to change notification settings - Fork 32
Colour banding issues #32
Comments
I've encountered some small colour banding issues too, but nothing terrible on my machine. xma/T480-Clover@c1c3193#diff-cd9999831fd158fd3c775b44b00907f2L461 You can try to add these changes to current PciRoot(0x0)/Pci(0x2,0x0) |
Issue seems to be mostly ameliorated. Using the "Gradients" test from EIZO, things seem much better. Colour banding is also far less noticeable in Launchpad and even the shadows of windows look better than before. I assume what banding remains is an issue of the quality of the display itself and not of the operating system. I have attached my zipped config.plist based on your latest 5.0.1 release, where I have made changes to PciRoot(0x0)/Pci(0x1f,0x3), PciRoot(0x0)/Pci(0x2,0x0) and also the boot arguments, changes that are in line with the commit you linked on xma's T480-Clover repo. EDIT: On an unrelated note, I have an external monitor connected via HDMI which wouldn't be seen automatically on boot (would have to unplug and plug it in again). Fixed using the |
Thanks for reporting success, May you run some tests for us?
|
IIRC, before adding the boot arguments macOS would crash in the boot process and the laptop would restart. Don't take my assumptions for granted, though; I am going to return with results to the tests you requested by the end of tomorrow. Cheers! |
Managed to do a few tests this evening. (1) BOOT ARGUMENTSTEST no. 1 TEST no. 2 TEST no. 3 TEST no. 4 (2) hda-gfx [WITH BOOT ARGUMENTS]TEST no. 5 (3) ORIGINAL device-id AND ig-platform-id [WITH BOOT ARGUMENTS, WITHOUT hda-gfx]TEST no. 6 TEST no. 7 Let me know if you need any other tests. Cheers. |
Your reports got me interested about this issue so I experimented with modifying config.plist and that difference is huge and by that I mean really huge. How I could ever looked at that before? It can be especially seen in gradient test you linked. This would be from now my priority for 5.1.0 release. It's interesting that only XMA's T480 config does not have these issues, both our and Tyler's does. It's really weird that macOS does not boot without these boot arguments, maybe reset NVRAM? Also, like I sad
Same for T480 does not have HDMI 2.0, nor any Kaby Lake R based ThinkPad. That should not block booting. I will test it more tomorrow |
I tried resetting the NVRAM from the bootloader, twice even, without success. Is there anything else I should be doing? |
Found this comment
I don’t think that its a good idea to spoof our machine as Skylake in the long term. I would ask about it on r/hackintosh today |
Good thread about color banding here There are dozens of reports about this issue and nobody ever fixed it differently than spoofing Skylake’s HD 520 which is something I wouldn’t like to do. |
Maybe try patching Framebuffer with Hackintool? Does @zombillano have some idea? I don’t actually know what to do now, nobody over internet found different solution ... |
I don't have any colour banding, at least I don't notice it at all |
@zombillano Then you are lucky man, but please try this Gradient test that @slorent mentioned Ideally, transition between colors should be 100% smooth, that's not exactly possible on this 50% sRGB panel but you can come really close to it. It is day and night difference between our actual config and the one that use HD520. There are many reports about this issue and nobody did not found solution. I asked about it on r/hackintosh and no one helped me. Probably only chance how to solve this while preserving UHD620 is to contact vit9696 |
I've tried it and still I cannot see any colour banding. I don't thing it is luck, it might be related to the fact that I installed a N140HCG-GQ2 panel on my T480, which is indeed a really good display compared with what my T480 had from factory.
Let me test this, although I don't think it would make so much difference to me.
Good luck with that, hope he does help us to solve this issue.. |
Yes, that's the reason. Did you noticed any significant battery life improvement with that low-power panel? |
Ok, I tried your new config.plist and first thing I notice is that it changes colour reproduction. Now the colours on my display look washed out. Not a bad thing by itself but I'm used to warmer colours. I don't notice any real difference running the test that @slorent provided. I think I have my old LCD panel that I took out from my T480 somewhere around here, but I don't promise anything. Although it is the worst panel you can have on a T480 (1366x768) and have awful colour reproduction I think it might be helpful to trace this issue.
I don't think so, at least not under macOS. Since I don't use linux/windows that often I don't know if it improves battery on those OSs. Maybe I'll test it in the future, but not very soon because my semester is about to start. |
I read the documentation for WhateverGreen and there is written:
Apparently this issue still exists on every macOS since Mojave and it seems that it was forgotten. I will open issue on Acidanthera bug tracker to see what can be do about that. |
They'll most likely close it without response, but doesn't hurt to give it a try. Maybe the third is the good one, since they've actually decided to ignore both the SSD issue and the iGPU one. I think they are pretty concentrated on their objectives to give solutions to most of the problems that doesn't have an easy fix, which if you see objectively is the best for the OC project as a whole. At the other hand, I have an issue with the middle button on my thinkpad, it used to let me open links in a new tab with a single middle button click, but now I need a double click to achieve the same. Didn't want to open a new issue just for that. Do you happen to know if it is intended to work like that? |
TrackPoint buttons are managed by VoodooRMI. It's probably a solution for scrolling without accidentally opening links. |
Thanks mate. I discovered something quite fun: You can wake up from sleep if you press the function key. My cat walked over my keyboard and I was amazed that the screen turned up, since I believed it was impossible to wake from keyboard key press :P |
So they closed that issue ( Expected though ) Until WEG fixes it, there is nothing I can do ( Will add HD520 setup to Post Install though ) |
I'm curious: What do you see at System Information > Graphics/Display without spoofing HD 520? I see this: As you can see it shows that it is using 24 bit depth... |
I see the exactly same thing, it is a driver issue. |
Closed as there is currently no fix except using HD 520 or replacing stock panel. Will add disclaimer in the README soon. |
For those who are struck by this bug I would like to ask if your machines are:
Would love to get some feedback to try to narrow the problem down. |
EDITED: As @zombillano pointed, only touch enabled Full HD panels and QHD machines come with 40 pin EDP cable |
Wrong. TN and IPS panels up to 1080p WITHOUT touchscreen uses 30 pin EDP connectors. Touchscreen panels and WQHD panels uses 40 pin EDP connectors. |
As a very slight improvement, here is a Whatevergreen-build, which allows Skylake-Framebuffers for KabyLake-R CPUs (which are seen as CoffeeLake by LiLu/WEG). This eliminates the need to use |
Thanks, did you tested these changes? I am getting Intel GPU Framebuffer related kernel panics with your version. Both with KBL-R and SKL. |
Yes, I'm running it right now. Skylake Device-ID and Framebuffer. Nothing else. Kext basically just changes KBL to SKL in line 116 & 119: |
@benbender Tried it again on already installed system (previously on installer), and it works well. Thanks |
Have you been able to get stable 4k-output @60Hz (via usb-c/DP) running on skylake? I got mostly just blinking, solid colors on screen and if this would be sorted out and somewhat stable, I would try to propose a workaround for our usecase in WEG-mainline. |
I really can't test 4K 60Hz output as highest resolution screen we have is UW-QHD ( LG's marketing name for 3440x1440 ) and I am limited by HDMI 1.4 bandwidth as I do not have any USB C to DP cable. |
Does 3440x1440 work at 60hz via hdmi 1.4? |
macOS allows only 30 Hz. I read though that on Windows it is possible to achieve 50 - 56 Hz |
Could you please elaborate how to properly spoof Skylake CPU? I tried various values for ig-platform-id and device-id with the kext you provided but each time got kernel panic? |
I had KP previously too, do not have that certain configuration any more. Remove every unnecessary boot-argument and use |
So the modified WhateverGreen and also |
Anyone got this running on latest big sur/opencore? I tried this patched WEG and platform-device-id and device-id and I get no backlight and backlight flickering every ~ 10sec. Please help if you can. |
Hey people. I use hp laptop g6 250 with i5 7200u kabylake. Screen is FHD Tn 1920x1080 panel. It has hd 620. With booting without anything in device properties and lilucpu=9 iget fully functional everything except the display has severe color banding issue. With edid injection I can reduce the amount of banding by 20% or smth, but that looks crappy. Sleep works ideally and wake has no issues too. When i spoof to skylake with lilucpu=8and platform id 1e19 and device id 1b19 graphics are really good, photoshop detects graphics as hd5xx iris. No or really unnoticeable amount of color banding. Everything is fine till I sleep my display or sleep. Sleep works as intended even with powernap enabled but when i wake up from display sleep screen starts flickering making it painfull to look at and unusable. Do you guys get this kin or issue with wake after display sleep? I have tried other standart skylake ids like 1619 and 1b19 but the flicker even worse and much more frequently. about the edid patches I tried them both with and without spoof. Have used FIXEDID app and havkintool too. Tried every kind of options they provide and everykind of display they have there as optiona. No success. Only thing i get from edid os just washed out colors. Tried manually changing the color depth in edid, no success. If i set it more than 10 bits the login screen sill be black, screen wont turn on after initial load of opencore. |
T480 has UHD 620, which in fact is different than the one that you have. Take a look over here https://github.com/acidanthera/WhateverGreen/blob/master/Manual/FAQ.IntelHD.en.md to find the correct config for your processor type and dGPU. Color banding was never really fixed in here, and this repo is kinda abandoned (@benbender got a X1C6 and left his T480 aside, @EETagent is using Fedora instead of macOS and @zombillano left so many months ago). Hope I've been helpful. |
Thank you for the reply. İ guess UHD 620 and hd 620 might behave the same way under mac os. İ even tried CFL, and it booted exactly the same way as people describe it for UHD, normally but without the brightness control. Whatever, thank you for the info. İf anybody with the same specs sees my comment please reply. Btw, have read the whole FAq of WEG. Nothing there helped. |
Hey,
I'm having some serious colour banding issues on my T480. I have the 8350U with UHD 620 graphics, 1080p FHD IPS display and I am using the EFI folder as is provided here in release 5.0.0, with the addition of the 8350U CPUFriend kext in the Other folder. I am running macOS Catalina 10.15.6 with the MacbookPro15,2 SMBIOS.
Is there anything I can do to solve this?
Thanks.
The text was updated successfully, but these errors were encountered: