Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VisDashboard] Size problem #37

Open
chseifert opened this issue Nov 9, 2015 · 8 comments
Open

[VisDashboard] Size problem #37

chseifert opened this issue Nov 9, 2015 · 8 comments
Assignees

Comments

@chseifert
Copy link

From the feedback we received through the chrome webstore (from a user):
"Hi, when I click on the dashboard I usually get the feedback "This visualization requires a larger screen area. Minimum width 750px and minimum height 200px." even if I use my big screen with 1920x1200.
Or is the dashboard not ready yet?"

  • To make it clear (that a huge monitor is not enough) - could we just rephrase it to "currently the window is of size AxB" (to indicate how much space is additionally needed)
@gerwald gerwald assigned chseifert and unassigned gerwald Nov 9, 2015
@gerwald
Copy link
Contributor

gerwald commented Nov 9, 2015

As it might not be so clear for all users, that the window is resizeable, wouldn't it be an idea, to automatically set the window to 750px, after the user clicks on the dashboard button?

I think we have spoken about this at the hackathon, but I am not sure any more, why we didn't do that / remove this functionality...

@chseifert
Copy link
Author

I think the result of the discussion was that because we allow for manual resizing of the window, we assume that once the user has resized the window s/he likes it that way. But I think we agreed also that we change it to "large enough" if not manual resizing has occurred before. Assign to Jörg to give us his view (maybe he remembers differently).

@chseifert chseifert assigned schloett and unassigned chseifert Nov 9, 2015
@mgrani
Copy link
Contributor

mgrani commented Nov 9, 2015

maybe there is a middle way: add some 'resizing' buttons: one to maximize, one for max width, half height. Could be left to the 'x" button

@chseifert
Copy link
Author

additional question to Gerwald: Did you receive the feedback as well? It was sent via the feedback form, but I don't know who should it receive. I did get it only, because it was explicitly sent by mail to me.

@gerwald
Copy link
Contributor

gerwald commented Nov 9, 2015

That the feedback form is sent via the logging framework afaik, and should not be displayed, when the screen size is too low (this is a bug).
Thus, I only get the feedback, if I ask for the whole logging result text file (what I haven't done so far)

@schloett
Copy link

schloett commented Nov 9, 2015

I like the idea of resizing buttons. Maybe in addition, we could introduce a message event? Something like eexcess.tooSmall with the minimal dimensions appended. This way, we would have a generic approach (required dimensions for the FacetScape differ from Dashboard). I would imagine something like:

if(tooSmall) {
  var dimensions = {
    width:800, // width in pixels
    height:300 // height in pixels
  }
  var msg = {
    event: 'eexcess.tooSmall',
    data: dimensions
  }
  window.top.postMessage(msg, '*');
} 

From the viewpoint of the chrome-extension, this event might cause a popup with a notification about the contentArea being to small, a link to resize it and two (pre-checked) checkboxes for not showing the popup again and making the resize the default behavior (which can be changed via the settings page).

@schloett
Copy link

Created a new issue for the resizing buttons #40. Any comments on the proposed event?

@gerwald
Copy link
Contributor

gerwald commented Nov 12, 2015

FYI: I have just implemented the "tooSmall" event, so the extension could react on this (eg when the dashboard is opened the first time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants