-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A big pile of refactoring #140
base: master
Are you sure you want to change the base?
Commits on May 21, 2018
-
Remove unused and redundant CongressMember methods
Removes aliases that make common congress_member instance methods into class methods. I wonder why those seemed useful.
Configuration menu - View commit details
-
Copy full SHA for 958e028 - Browse repository at this point
Copy the full SHA 958e028View commit details -
* shorten long lines * move single-use method into the only place it's used
Configuration menu - View commit details
-
Copy full SHA for 1972c6e - Browse repository at this point
Copy the full SHA 1972c6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ea4c94 - Browse repository at this point
Copy the full SHA 1ea4c94View commit details -
Little refactors to debug_controller_spec
* DRY up last_response_json * use `let` to create instance methods * use string interpolation instead of `'' + foo.to_s`
Configuration menu - View commit details
-
Copy full SHA for 861bdb7 - Browse repository at this point
Copy the full SHA 861bdb7View commit details -
Refactor CongressMemberAction model
* break the crazy-long execute method into smaller methods * move some code that doesn't pertain to the model out of the model * fewer nested if statements * put `extends` calls and ActiveRecord methods at the top of the file * don't pass the CongressMember, the record already knows its CongressMember.
Configuration menu - View commit details
-
Copy full SHA for 4ad4ff5 - Browse repository at this point
Copy the full SHA 4ad4ff5View commit details -
* remove unused `fill_out_form!` method * shallower if statments * move code into named methods
Configuration menu - View commit details
-
Copy full SHA for 03fb25a - Browse repository at this point
Copy the full SHA 03fb25aView commit details -
Split the giant factories.rb into smaller, single-model factories.
Configuration menu - View commit details
-
Copy full SHA for a8ec759 - Browse repository at this point
Copy the full SHA a8ec759View commit details -
Be firm about the possible CongressMemberAction actions
Move the list into a constant that the wider app can rely on
Configuration menu - View commit details
-
Copy full SHA for fd55f6a - Browse repository at this point
Copy the full SHA fd55f6aView commit details -
* Everything is a class method; use class << self instead of declaring individually * Remove unused methods
Configuration menu - View commit details
-
Copy full SHA for 9e04834 - Browse repository at this point
Copy the full SHA 9e04834View commit details -
Move delayed_job tasks into their own file
Smaller, more focused files are more legible than larger ones.
Configuration menu - View commit details
-
Copy full SHA for c362b33 - Browse repository at this point
Copy the full SHA c362b33View commit details -
Replace demeter violation in CongressMember
* delegate to a named scope in CongressMemberAction * use new hash syntax
Configuration menu - View commit details
-
Copy full SHA for 5dd061e - Browse repository at this point
Copy the full SHA 5dd061eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f81929 - Browse repository at this point
Copy the full SHA 1f81929View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fcb225 - Browse repository at this point
Copy the full SHA 2fcb225View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8c7daf - Browse repository at this point
Copy the full SHA f8c7dafView commit details -
Move PhantomJS fillers into their own file
Now it will be easy to swap out PhantomJS with something else! * the CongressMemberAction model doesn't need to know about Capybara, * move screenshot methods into their own file
Configuration menu - View commit details
-
Copy full SHA for 69ec7c2 - Browse repository at this point
Copy the full SHA 69ec7c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c5f15a6 - Browse repository at this point
Copy the full SHA c5f15a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a6b7e57 - Browse repository at this point
Copy the full SHA a6b7e57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84204e9 - Browse repository at this point
Copy the full SHA 84204e9View commit details
Commits on May 22, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 5b83272 - Browse repository at this point
Copy the full SHA 5b83272View commit details -
Configuration menu - View commit details
-
Copy full SHA for 40bfa92 - Browse repository at this point
Copy the full SHA 40bfa92View commit details -
Refactor rake congress_member:fill_out_all
Pull the logic into a tidy lib class
Configuration menu - View commit details
-
Copy full SHA for d524140 - Browse repository at this point
Copy the full SHA d524140View commit details
Commits on May 23, 2018
-
* code style consistency * DRY up repeated logic * keep constants in one place * more expressive names
Configuration menu - View commit details
-
Copy full SHA for 3ae57ca - Browse repository at this point
Copy the full SHA 3ae57caView commit details
Commits on May 24, 2018
-
* DRY up repeated logic * use .map instead of instantiating and pushing to an ary * fix some typos
Configuration menu - View commit details
-
Copy full SHA for 4b8753f - Browse repository at this point
Copy the full SHA 4b8753fView commit details