-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report replaced widgets in the popup UI #2688
Comments
Are there any UI guidelines for implementing this change? |
There isn't a UI guidelines doc we've been following for this change, though some work has taken place in #2799 which follows a few other recent branches of work that have gone towards a similar goal of adding more expressive content to the extension popup |
I had some thoughts regarding the UI in #2758 (comment) |
@clasick if you'd like to contribute or collaborate on #2799, let's talk! Feel free to leave any questions or comments on #2799, or if you'd like to join one of our upcoming biweekly developer meetings, we can chat about it there. Meeting details can be found here |
Firefox is adding click-to-activate widgets ("Smartblock embeds"), controlled through the Tracking Protections panel: |
Sometimes widget replacement fails (#2331, #1542 (comment)), and sometimes it succeeds but our placeholder is unusable for some reason (Spotify, SoundCloud on Tumblr (#787), #2281).
When replacement fails for a blocked widget that provides/is required for desired functionality, it's not clear why a video is missing, a form that requires reCAPTCHA doesn't work, etc. as Privacy Badger doesn't show anything inside the page, nor anything specifically about video players or CAPTCHA providers in the popup.
When replacement succeeds but clicking our placeholder doesn't do anything, there is no obvious way to activate it in another way.
We should add UI to the popup to show the widgets that should have been replaced on the current page. This should help make it clear what Privacy Badger meant to replace. This will also allow users to activate each widget regardless of whether its replacement is present and usable.
The text was updated successfully, but these errors were encountered: