Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty node list is currently not supported #81

Closed
Adhara3 opened this issue Aug 30, 2024 · 3 comments · Fixed by #83
Closed

Empty node list is currently not supported #81

Adhara3 opened this issue Aug 30, 2024 · 3 comments · Fixed by #83
Assignees
@Whitehouse112
Labels
bug Something isn't working
Milestone
1.7

Comments

@Adhara3
Copy link
Collaborator

Adhara3 commented Aug 30, 2024

The tag BU_: with no nodes produces a parsing error.
We should tolerate this.
@Adhara3 Adhara3 added the bug Something isn't working label Aug 30, 2024
@Uight
Copy link
Contributor

Uight commented Aug 30, 2024

true and easy enough. and as it is internally a hashset thats always initialized it wouldn't cause the public IEnumerable Nodes {get;} to ever be null which i like ;)

@Uight Uight mentioned this issue Aug 31, 2024
Open
@Adhara3 Adhara3 added this to the 1.7 milestone Aug 31, 2024
@Adhara3 Adhara3 self-assigned this Aug 31, 2024
@Adhara3
Copy link
Collaborator Author

Adhara3 commented Aug 31, 2024

@Whitehouse112 can you please take care of this one?

Thx
A

@Whitehouse112
Copy link
Contributor

Of course, no problem

@Adhara3 Adhara3 assigned Whitehouse112 and unassigned Adhara3 Sep 2, 2024
Whitehouse112 added a commit to Whitehouse112/DbcParser that referenced this issue Sep 3, 2024
@Whitehouse112
EFeru#81 Empty node list is now supported. Parsers and regex refactor…
a7d733f 
…ing to improve code readability
@Adhara3 Adhara3 linked a pull request Sep 3, 2024 that will close this issue
#81 Empty node list is now supported. Regex refactoring #83
Merged
Adhara3 added a commit that referenced this issue Sep 3, 2024
@Adhara3
Merge pull request #83 from Whitehouse112/regex_refactoring
40c79a0 
#81 Empty node list is now supported. Regex refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Whitehouse112 Whitehouse112

Labels
bug Something isn't working
Projects
None yet
Milestone
1.7
Development

Successfully merging a pull request may close this issue.

#81 Empty node list is now supported. Regex refactoring Whitehouse112/DbcParser
3 participants
@Adhara3 @Whitehouse112 @Uight