-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for keyword BO_TX_BU_ #86
Comments
Ill take care of this one. @Adhara3 one question though how would we like to add the additional transmitters? The errors i would handle is: parsing fail, message not found and duplicate transmitter (would still add all non duplicates in that case) |
Can confirm that CANdb++ requires final semicolon, otherwise syntax error, parsing failed. I would follow this, which is coherent with specs.
Oh well, another proof that dbc and specs are shitty as fu*k. Jokes apart,
In v2.0 Transmitter and receivers is signal are Nodes, no longer strings. If Transmitter cardinality can be > 1, then Transmitters should also be a collection of some kind. // Version 1.8, do not brek API
string Transmitter;
string[] AdditionalTransmitters;
// Version 2.0
Node Transmitter;
IReadOnlyCollection<Node> AdditionalTransmitters;
// Version 2.0b, since we are already breaking the API
IReadOnlyCollection<Node> Transmitters; // We lose the info about the main one.... needed? Probably keeping the distinction is unnecessary but at least for version 1.8 would help with having a backward compatible API |
Currently
BO_TX_BU_
is not parsedThe text was updated successfully, but these errors were encountered: