Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPC2 download is erratic #36

Closed
lucventurini opened this issue Dec 7, 2020 · 9 comments · Fixed by #40
Closed

CPC2 download is erratic #36

lucventurini opened this issue Dec 7, 2020 · 9 comments · Fixed by #40

Comments

@lucventurini
Copy link
Collaborator

Two possible solutions here:

  1. Use a different mirror from the official, unreliable one. I have cloned the code myself here ago, but this repo seems slightly more up to date:

https://github.com/biocoder/CPC2/

  1. Potentially find a different source for this?
@cschu
Copy link
Collaborator

cschu commented Dec 7, 2020

One could even think of just porting the code (it's not rocket science and terribly written). The current installation requires to port it to python3 anyway and I agree, the download source always seemed to be quite unstable. If I remember correctly, @gemygk was looking (or at least planning to) at alternatives earlier this year (or was that for a different tool?)

@gemygk
Copy link
Collaborator

gemygk commented Dec 7, 2020

@lucventurini
as @cschu mentioned this is related to #31 and I was working on it and need to look at it again.

@swarbred
Copy link

CPC2 related it also errors with ambiguity codes that are not N as just discovered via running with the arabidopsis genome. If we stick with CPC2 we might want to clean the provided genome fasta as a preprocessing step (i.e. the equivalent of sed '/^[^>]/ s/[^AGTC]/N/gi' )

@lucventurini
Copy link
Collaborator Author

Hi,

any progress on this by any chance? It popped up again today because I am trying to move Minos to GitHub actions and CPC2 is part of the tests.

@cschu
Copy link
Collaborator

cschu commented Jan 20, 2021

Last time I looked it didn't feel impossible to just port CPC2 to an inhouse version... I didn't do that for time reasons and because I didn't want to deal with the potential license implications*. (I did patch it to Python3 compatibility within the container definition, though). But tbh, one can just rip the functionality out, and put it into an internal script, potentially using scikit to replace the svm part.

*I might have contacted the devs at some point, but if so, there was never any reply.

@swarbred
Copy link

Hi All,

What are the "realistic" options to resolve this given everyones time / ability to contribute?

@lucventurini
Copy link
Collaborator Author

Hi @swarbred

As I was writing earlier, the quickest and dirtiest would be to change the download location to the GitHub clone:

https://github.com/biocoder/CPC2

Specifically if we want to just download the latest:

wget --no-check-certificate --content-disposition https://github.com/biocoder/CPC2/tarball/9a2b596

@cschu
Copy link
Collaborator

cschu commented Jan 20, 2021

https://github.com/biocoder/CPC2

seems like problem solved, no? could also git clone it during installation

@lucventurini
Copy link
Collaborator Author

@swarbred @cschu

I should have solved this, see #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants