-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the main install in CI #301
Labels
ci/cd
Continuous intergration/development
Comments
Thanks for creating this issue, that was indeed an oversight. I think once we add sample data to an online repo (likely zenodo) (#302), we will rewrite/simplify build.yml, as it will no longer be necessary to run from a container. I think it's not worthwhile fixing this before then. I created #303 for that. |
The sample data is available already. I put the link in Teams a few days ago.
https://zenodo.org/records/13847654
…________________________________
From: Dani Bodor ***@***.***>
Sent: Monday, September 30, 2024 10:06:46 PM
To: EIT-ALIVE/eitprocessing ***@***.***>
Cc: Peter Somhorst ***@***.***>; Author ***@***.***>
Subject: Re: [EIT-ALIVE/eitprocessing] CI tests only cover [dev,publishing] install (Issue #301)
Waarschuwing: Deze e-mail is afkomstig van buiten de organisatie. Klik niet op links en open geen bijlagen, tenzij u de afzender herkent en weet dat de inhoud veilig is.
Caution: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Thanks for creating this issue, that was indeed an oversight. I think once we add sample data to an online repo (likely zenodo), we will rewrite/simplify build.yml, as it will no longer be necessary to run from a container. I think it's not worthwhile fixing this before then.
—
Reply to this email directly, view it on GitHub<#301 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6QKKNSWZC747C2PPWJZQSTZZGVNNAVCNFSM6AAAAABPDEKUZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBUGA2TEOJRGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the CI build uses the [dev,publishing] install, but things should also work for the "normal install".
See #299.
(EDITED by @DaniBodor )
The text was updated successfully, but these errors were encountered: