Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking for sonar version - M750D compatibility. #5

Open
ChristianWesterdahl opened this issue Aug 26, 2024 · 1 comment
Open

Checking for sonar version - M750D compatibility. #5

ChristianWesterdahl opened this issue Aug 26, 2024 · 1 comment

Comments

@ChristianWesterdahl
Copy link

In the file oculus_sonar_node.cpp, line 172 to 177 you check for the part number of the sonar, throwing an error if it is not that of the M1200D sonar.

Why do you do this check in a wrapper for a driver that supports multiple sonar models? We are attempting to use this code with an M750D - can we simply remove this check? Or would we encounter problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@ChristianWesterdahl and others