-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent sorting compared with other libraries #5
Comments
Labels are sorted using this hash algorithm: https://github.com/EPD-Libraries/msbt/blob/main/src/sections/label_section.cpp#L7-L14 Source is from CLMS (which iirc is based off official RE): https://github.com/Trippixyz/CLMS/blob/main/LMS.cs#L178-L191 |
Although, it doesn't look like that sorts within groups, in which case it's not sorted at all and is just written in the same order as the yaml. Could be wrong though, it's been a while since I've looked at this code. |
Since I still can't help you directly with the code, I'll share another example of a tool that seems to extract data in the same way as Kurrimu, but it's written in pure C. |
As far as I can tell, that doesn't sort |
When I have more time I'll try to look into this further. |
I don't think it's a bug, but rather a question about how the text extraction is organized.
In the file PouchContent.msbt, we have item descriptions and their names.
When we use a tool that has been around for some time, like (Kuriimu), these strings come organized as follows: item description, item name.
However, when we use the msbt_yml tool, it ends up organizing these strings differently, making it a bit more complicated to translate because we have to search for the corresponding description for each specific item.
Once the text passes through the msbt_yml tool, it will always be organized in that way.
I'll attach some screenshots of how the extraction looks before and after passing through msbt_yml."
Before
![msbt_kuriimu](https://private-user-images.githubusercontent.com/45742711/255342198-263d74e8-5ae9-496e-9061-079e49f00560.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjkyMTcsIm5iZiI6MTczOTI2ODkxNywicGF0aCI6Ii80NTc0MjcxMS8yNTUzNDIxOTgtMjYzZDc0ZTgtNWFlOS00OTZlLTkwNjEtMDc5ZTQ5ZjAwNTYwLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDEwMTUxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ5ODNjMTE4MTFiYmRlM2FjOTNjNTcxM2M5NDMzMWNlM2ZhM2IwOTMxZGY4NTZlYjIyMzYzYzQ5YjM1ZmQ1ZGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._f-RgYepwp9ThvRSvBwu5Qujs0bEqMzul5lDYV2yGRI)
After
![msbt_yml](https://private-user-images.githubusercontent.com/45742711/255342223-8698878b-d1d7-4fce-a6bb-06ac3bb45545.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjkyMTcsIm5iZiI6MTczOTI2ODkxNywicGF0aCI6Ii80NTc0MjcxMS8yNTUzNDIyMjMtODY5ODg3OGItZDFkNy00ZmNlLWE2YmItMDZhYzNiYjQ1NTQ1LmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDEwMTUxN1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ2MjJkODgzMDMwNTNkNzdiOTBiNGE4NWQ4ZjNkNzgwYjU3ZGNjYzVhMTkwMzQwZGZkMDYxMWY1MDFlNjBmMzgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KLi649sbasxIQqiUUZY_6Gq4K0kpvPTV62aXEKPX3I4)
Thanks a lot for the tool, it's been very useful to use the .yml files on a review site.
The text was updated successfully, but these errors were encountered: