-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start enforcing pre-commit? #45
Comments
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
soxofaan
added a commit
that referenced
this issue
Oct 17, 2024
I already addressed the reported issues on main branch and created PR #46 to add it as github action on PRs |
soxofaan
added a commit
that referenced
this issue
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I added a pre-commit config pretty early in June to get some basic static code quality management in place. At the moment using pre-commit is optional (opt-in) for developers and I noticed that quite some code style issues are slipping in the repo
e.g. after running
pre-commit run --all-files
to fix various issue, I get these diff stats currently:While I understand that playing pedantic code style police is not the point of this project, I still think this project plays an exemplary role in the ecosystem and we should set some bar related to code quality and give nice and consistent examples.
I think we can start with running a pre-commit check as github action to flag new issues
The text was updated successfully, but these errors were encountered: