Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
bugfix for fgrg_rofi computation
Thanks to @billsacks who discovered this issue!
Specific notes
The current logic for DGCL%NOEVOLVE for exporting Fgrg_rofi is the following:
However, what Fgrg_rofi should only be exported if
is_in_active_grid(usrf(ng))
is true. And the code should be the following:Note - since by default in coupled runs DGC%NOEVOLVE only sends new Fgrg_rofi back yearly - comparisons with previous runs will show no answer changes until the second year of the run.
Contributors other than yourself, if any: @billsacks
CDEPS Issues Fixed: #294
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers: Answer will differ after the first coupling period where valid data is received by DGLC (by default this is one year).
Any User Interface Changes (namelist or namelist defaults changes): No
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): This was discovered and resolved in a NorESM case using the compset and grid:
So this should apply equally to CESM cases.
Hashes used for testing:
CDEPS: cdeps1.0.44 (with dglc_datamode_noevolve_mod.F90 bug fix)
CMEPS: cmeps1.0.13 (with med_diag_mod.F90 bug fix)