Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify subset_data for CRUJRA (currently hardcoded for GSWP3 and rather brittle). #2960

Open
Tracked by #1895
ekluzek opened this issue Feb 11, 2025 · 2 comments
Open
Tracked by #1895
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science usability Improve or clarify user-facing options

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Feb 11, 2025

subset_data is hardwired to work with datm_gswp3.
The default datm dataset is changing for clm6 to CRUJRA2024.

I added this comment to subset_data.py in #2956:

    # TODO issue #1895: allow datm_crujra, which also affects
    #      tools/site_and_regional/default_data_1850.cfg
    #      tools/site_and_regional/default_data_2000.cfg
    #      python/ctsm/test/testinputs/default_data.cfg

and posted this comment.

@wwieder
Copy link
Contributor

wwieder commented Feb 11, 2025

I'll note that I have an equally hard and brittle application of subset data that works for CRUJRA (currently unavailable on Derecho).

  • In the short term, we can bring this option in (having something that's functional with CRUJRA seems critical).
  • Alternatively, maybe it's not too difficult to make less brittle python code that can handle both options? (not sure how much we can support multiple datm products in our subsetting tools)?

@wwieder wwieder added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science usability Improve or clarify user-facing options labels Feb 11, 2025
@wwieder wwieder added this to the ctsm6.0.0 (code freeze) milestone Feb 11, 2025
@slevis-lmwg

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science usability Improve or clarify user-facing options
Projects
None yet
Development

No branches or pull requests

3 participants