Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multi root trusted ca #923

Merged
merged 8 commits into from
Oct 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@ libcurl:
cmake_condition: "EVEREST_DEPENDENCY_ENABLED_LIBCURL"

# EvseSecurity
# This has to appear before libocpp in this file since it is also a direct dependency of libocpp
# and would otherwise be overwritten by the version used there
# This has to appear before libocpp in this file since it is also a direct dependency
# of libocpp and would otherwise be overwritten by the version used there
libevse-security:
git: https://github.com/EVerest/libevse-security.git
git_tag: v0.8.0
git_tag: v0.9.1
cmake_condition: "EVEREST_DEPENDENCY_ENABLED_LIBEVSE_SECURITY"

# OCPP
Expand Down
20 changes: 20 additions & 0 deletions interfaces/evse_security.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,26 @@ cmds:
description: The response to the requested command
type: object
$ref: /evse_security#/GetCertificateInfoResult
get_all_valid_certificates_info:
description: >-
Finds the latest valid leafs, for each root certificate that is present on the filesystem,
and returns all the newest valid leafs that are present for different roots
arguments:
certificate_type:
description: Specifies the leaf certificate type
type: string
$ref: /evse_security#/LeafCertificateType
encoding:
description: Specifies the encoding of the key
type: string
$ref: /evse_security#/EncodingFormat
include_ocsp:
description: Specifies whether per-certificate OCSP data is also requested
type: boolean
result:
description: The response to the requested command
type: object
$ref: /evse_security#/GetCertificateFullInfoResult
get_verify_file:
description: Command to get the file path of a CA bundle that can be used for verification
arguments:
Expand Down
1 change: 1 addition & 0 deletions lib/staging/evse_security/conversions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,7 @@ types::evse_security::OCSPRequestDataList to_everest(evse_security::OCSPRequestD
types::evse_security::CertificateInfo to_everest(evse_security::CertificateInfo other) {
types::evse_security::CertificateInfo lhs;
lhs.key = other.key;
lhs.certificate_root = other.certificate_root;
lhs.certificate = other.certificate;
lhs.certificate_single = other.certificate_single;
lhs.password = other.password;
Expand Down
20 changes: 20 additions & 0 deletions modules/EvseSecurity/main/evse_securityImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,26 @@ evse_securityImpl::handle_get_leaf_certificate_info(types::evse_security::LeafCe
return response;
}

types::evse_security::GetCertificateFullInfoResult
evse_securityImpl::handle_get_all_valid_certificates_info(types::evse_security::LeafCertificateType& certificate_type,
AssemblyJohn marked this conversation as resolved.
Show resolved Hide resolved
types::evse_security::EncodingFormat& encoding,
bool& include_ocsp) {
types::evse_security::GetCertificateFullInfoResult response;

const auto full_leaf_info = this->evse_security->get_all_valid_certificates_info(
conversions::from_everest(certificate_type), conversions::from_everest(encoding), include_ocsp);

response.status = conversions::to_everest(full_leaf_info.status);

if (full_leaf_info.status == evse_security::GetCertificateInfoStatus::Accepted) {
for (const auto& info : full_leaf_info.info) {
response.info.push_back(conversions::to_everest(info));
}
}

return response;
}

std::string evse_securityImpl::handle_get_verify_file(types::evse_security::CaCertificateType& certificate_type) {
return this->evse_security->get_verify_file(conversions::from_everest(certificate_type));
}
Expand Down
3 changes: 3 additions & 0 deletions modules/EvseSecurity/main/evse_securityImpl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ class evse_securityImpl : public evse_securityImplBase {
virtual types::evse_security::GetCertificateInfoResult
handle_get_leaf_certificate_info(types::evse_security::LeafCertificateType& certificate_type,
types::evse_security::EncodingFormat& encoding, bool& include_ocsp) override;
virtual types::evse_security::GetCertificateFullInfoResult
handle_get_all_valid_certificates_info(types::evse_security::LeafCertificateType& certificate_type,
types::evse_security::EncodingFormat& encoding, bool& include_ocsp) override;
virtual std::string handle_get_verify_file(types::evse_security::CaCertificateType& certificate_type) override;
virtual int handle_get_leaf_expiry_days_count(types::evse_security::LeafCertificateType& certificate_type) override;
virtual bool handle_verify_file_signature(std::string& file_path, std::string& signing_certificate,
Expand Down
21 changes: 21 additions & 0 deletions types/evse_security.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,9 @@ types:
key:
description: The path of the PEM or DER encoded private key
type: string
certificate_root:
description: The PEM of the root certificate that issued this leaf
type: string
certificate:
description: The path of the PEM or DER encoded certificate chain
type: string
Expand Down Expand Up @@ -260,4 +263,22 @@ types:
description: The requested info
type: object
$ref: /evse_security#/CertificateInfo
GetCertificateFullInfoResult:
description: Response to the command get_all_valid_certificates_info
type: object
required:
- status
- info
properties:
status:
description: The status of the requested command
type: string
AssemblyJohn marked this conversation as resolved.
Show resolved Hide resolved
$ref: /evse_security#/GetCertificateInfoStatus
info:
description: The requested info
type: array
items:
minimum: 0
type: object
$ref: /evse_security#/CertificateInfo

Loading