Accept bank cards only for specific connectors #997
+223
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wku12
requested review from
SirVer,
dorezyuk,
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
wku12
force-pushed
the
feat/ad_hoc_restrictions_for_payment_terminal
branch
2 times, most recently
from
299f485 to
0947e9b
Compare
dorezyuk
reviewed
Dec 18, 2024
dorezyuk
reviewed
Dec 18, 2024
dorezyuk
reviewed
Dec 18, 2024
wku12
force-pushed
the
feat/ad_hoc_restrictions_for_payment_terminal
branch
from
0947e9b to
7a38aa8
Compare
Signed-off-by: Wojciech Kula <[email protected]>
wku12
force-pushed
the
feat/ad_hoc_restrictions_for_payment_terminal
branch
from
7a38aa8 to
27b8e01
Compare
dorezyuk
reviewed
Dec 18, 2024
dorezyuk
reviewed
Dec 18, 2024
|
|
||
| /// For which connectors credit cards should be accepted | ||
| /// If None, authentication happens to all connectors | ||
| credit_cards_connectors: Vec<i64>, |
There was a problem hiding this comment.
None can be only true for Option. Maybe lets make it an option?
There was a problem hiding this comment.
It doesn't have to. It's a config - it should always be set to something. Even empty
There was a problem hiding this comment.
I mean in the comment above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add to the config a comma separated list (since config can't have arrays) of connectors to which the bank cards should be accepted
Issue ticket number and link
Checklist before requesting a review