Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid error message when an certificate is expired #60

Closed
AssemblyJohn opened this issue Mar 18, 2024 · 2 comments
Closed

Invalid error message when an certificate is expired #60

AssemblyJohn opened this issue Mar 18, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@AssemblyJohn
Copy link
Collaborator

AssemblyJohn commented Mar 18, 2024

Describe the bug

When a leaf certificate is expired and it is requested from the module, instead of properly outputting the error with a 'Could not find certificate for given private key' or something long those lines, the error that is outputted is related to a missing private key, which is not the case.

To Reproduce

Attempt to request an expired leaf certificate.

Anything else?

No response

@AssemblyJohn AssemblyJohn added the bug Something isn't working label Mar 18, 2024
@AssemblyJohn AssemblyJohn self-assigned this Mar 18, 2024
@james-ctc
Copy link
Collaborator

An example of the warning in the log

manager[10051]: 2024-03-14 17:29:31.011941 [WARN] evse_security:E evse_security::GetKeyPairResult evse_security::EvseSecurity::get_key_pair_internal(evse_security::LeafCertificateType, evse_security::EncodingFormat) :: Could not find private key for the selected certificate: (Could not find private key for given certificate: /etc/everest/certs/client/csms/CPO_CERT_CHAIN.pem key path: /etc/everest/certs/client/csms)

@AssemblyJohn
Copy link
Collaborator Author

Closed with error management PR: #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants