Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify chapter on authorisation response #66

Open
pa-rw opened this issue Jul 31, 2024 · 2 comments
Open

Clarify chapter on authorisation response #66

pa-rw opened this issue Jul 31, 2024 · 2 comments
Labels
EWC RFC 001 Issue Verifiable Credential

Comments

@pa-rw
Copy link

pa-rw commented Jul 31, 2024

The authorisation response and the DID authentication are conflated making the chapter a bit confusing. Here are some suggestions of changes:

Parameters response_type and response_mode are mixed up. It should say:
"In this case, the authorisation response will contain a response_mode parameter with the value direct_post"

"Query params for the authorisation response are given below:" should be "Query params for the DID authentication request are given below:"

"The holder wallet then responds with an id_token signed by the DID to the direct post endpoint." should be "The holder wallet then responds with an id_token signed by the DIDs private key and the state parameter from the DID authentication request to the direct post endpoint." Mention that the nonce from the DID authentication request is included in the id_token. Update the example and include the state parameter.

"If additional details are not requested, the credential issuer will send an authorisation response with a code query parameter containing the short-lived authorisation code." should be "If additional details are not requested, the credential issuer will send an authorisation response with a code query parameter containing the short-lived authorisation code and the state parameter from the authorisation request". Update the example and include the state parameter.

Clarify that the state parameter of the authorisation request and the DID authentication requests are different parameters. The first one is generated by the Wallet and the second is generated by the Issuer. The same goes for the nonce parameter (the nonce parameter is only included in the authorisation request example and not in the table of query parameters).

@lalc
Copy link
Contributor

lalc commented Sep 4, 2024

Which RFC is this issue raised against?

@pa-rw
Copy link
Author

pa-rw commented Sep 9, 2024

Which RFC is this issue raised against?

It is raised against RFC001

@georgepadayatti georgepadayatti added the EWC RFC 001 Issue Verifiable Credential label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EWC RFC 001 Issue Verifiable Credential
Projects
None yet
Development

No branches or pull requests

3 participants