Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background color of URL input field does not match figma design #182

Closed
kwerber opened this issue Jan 17, 2025 · 1 comment · Fixed by #186
Closed

Background color of URL input field does not match figma design #182

kwerber opened this issue Jan 17, 2025 · 1 comment · Fixed by #186
Assignees
@Hell3ringer
Labels
branding How should our app be designed frontend Frontend related task good first issue Good for newcomers

Comments

@kwerber
Copy link
Collaborator

kwerber commented Jan 17, 2025

Describe the bug

The background color of the UrlInput field inside the main top bar currently does not match the background color of our figma design.

To Reproduce

  1. Open the application
  2. Look at the url input field
  3. Look at our figma design
  4. Compare the background colors

Expected behavior

The background color should align with our figma design.

Screenshots/Video

Figma Design:

Image

Current implementation:

Image

Desktop (please complete the following information):

  • OS: Windows 11
  • Version v0.0.1

Additional context

  • The HTTP method select background should have the background color: #111111
  • The URL input should have the background color: #1F1F1F
@kwerber kwerber added branding How should our app be designed bug frontend Frontend related task good first issue Good for newcomers labels Jan 17, 2025
@kwerber kwerber changed the title Fix background color of URL input field Background color of URL input field does not match figma design Jan 17, 2025
Hell3ringer added a commit to Hell3ringer/trufos that referenced this issue Jan 20, 2025
@Hell3ringer
EXXETA#182 - fixed url input field color according to figma
b6b51cc
@Hell3ringer
Copy link
Contributor

Hi @kwerber
I have made a fix and attached the issue to the PR . Please review if it looks fine.
Thanks

@SoulKa SoulKa linked a pull request Jan 22, 2025 that will close this issue
#182 - fixed url input field color according to figma #186
Merged
7 tasks
@giemic8 giemic8 removed the bug label Jan 23, 2025
giemic8 pushed a commit to Hell3ringer/trufos that referenced this issue Jan 24, 2025
@Hell3ringer @giemic8
EXXETA#182 - fixed url input field color according to figma
ee6c703
Hell3ringer added a commit to Hell3ringer/trufos that referenced this issue Jan 25, 2025
@Hell3ringer
EXXETA#182 - added font css class, used tailwind css class
ed4600e
Hell3ringer added a commit to Hell3ringer/trufos that referenced this issue Jan 27, 2025
@Hell3ringer
EXXETA#182 - used tailwind font style
9af902f
@giemic8 giemic8 mentioned this issue Jan 28, 2025
Merged
7 tasks
giemic8 pushed a commit that referenced this issue Jan 28, 2025
@Hell3ringer
#182 - fixed url input field color according to figma (#186)
cc520a9 
* #182 - fixed url input field color according to figma

* #182 - added font css class, used tailwind css class

* #182 - used tailwind font style

---------

Co-authored-by: Michael Giek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hell3ringer Hell3ringer

Labels
branding How should our app be designed frontend Frontend related task good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#182 - fixed url input field color according to figma Hell3ringer/trufos
3 participants
@giemic8 @kwerber @Hell3ringer