Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Formatting Setup #87

Closed
SoulKa opened this issue Oct 17, 2024 · 0 comments · Fixed by #89
Closed

Code Formatting Setup #87

SoulKa opened this issue Oct 17, 2024 · 0 comments · Fixed by #89
Assignees
Labels
good first issue Good for newcomers setup Initial Setup has to be done
Milestone

Comments

@SoulKa
Copy link
Collaborator

SoulKa commented Oct 17, 2024

In order to prevent code changes for actually untouched code, we want to have a single formatting rule which always applies. This also enforces correctly formatted code on commits.

Currently, we often have differently formatted code for different users.

Acceptance Criteria

  • There's a prettier configuration (or similar) that defines a single source of truth for our code formatting. This actually already exists
  • Incorrect formatted code cannot be committed or raises an error in our CI pipeline
  • If applicable: documentation exists how to setup automatic formatting in IntelliJ and VSCode
@SoulKa SoulKa added good first issue Good for newcomers setup Initial Setup has to be done labels Oct 17, 2024
@SoulKa SoulKa added this to the MVP milestone Oct 17, 2024
@AmirHassanConsulting AmirHassanConsulting self-assigned this Oct 18, 2024
@AmirHassanConsulting AmirHassanConsulting linked a pull request Oct 18, 2024 that will close this issue
7 tasks
AmirHassanConsulting added a commit that referenced this issue Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers setup Initial Setup has to be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants